Skip to content

Conversation

lw
Copy link
Contributor

@lw lw commented May 31, 2021

Stack from ghstack:

Reland of #58425

Now that callbacks can provide pre-extracted DataPtrs, let's do so. This will become of crucial importance in the next PR, where some of these futures will become CUDA-aware, and thus they will try to extract DataPtrs on their own, but they would fail to do so here because Message isn't "inspectable".

Differential Revision: D28623888

… a Message

Reland of #58425

Now that callbacks can provide pre-extracted DataPtrs, let's do so. This will become of crucial importance in the next PR, where some of these futures will become CUDA-aware, and thus they will try to extract DataPtrs on their own, but they would fail to do so here because Message isn't "inspectable".

Differential Revision: [D28623888](https://our.internmc.facebook.com/intern/diff/D28623888/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added oncall: distributed Add this issue/PR to distributed oncall triage queue cla signed labels May 31, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 31, 2021

💊 CI failures summary and remediations

As of commit b3f9200 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the previous attempt. The change in reland is updating internal related code to use intrusive_ptr as well.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3af6ff9.

@facebook-github-bot facebook-github-bot deleted the gh/lw/196/head branch June 5, 2021 14:17
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
… a Message (pytorch#59208)

Summary:
Pull Request resolved: pytorch#59208

Reland of pytorch#58425

Now that callbacks can provide pre-extracted DataPtrs, let's do so. This will become of crucial importance in the next PR, where some of these futures will become CUDA-aware, and thus they will try to extract DataPtrs on their own, but they would fail to do so here because Message isn't "inspectable".
ghstack-source-id: 130202845

Test Plan: CI

Reviewed By: mrshenli

Differential Revision: D28623888

fbshipit-source-id: 1aa4bde8014870c071685ba8f72d5f3f01f0a512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants