Skip to content

Fix MaxPool default pad documentation #59404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Varal7
Copy link
Contributor

@Varal7 Varal7 commented Jun 3, 2021

Fixes #33384

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 3, 2021

💊 CI failures summary and remediations

As of commit fa49be6 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@Varal7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #59404 (fa49be6) into master (f87aa23) will decrease coverage by 0.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #59404      +/-   ##
==========================================
- Coverage   76.47%   75.48%   -1.00%     
==========================================
  Files        2022     2038      +16     
  Lines      202510   208230    +5720     
==========================================
+ Hits       154872   157184    +2312     
- Misses      47638    51046    +3408     

@facebook-github-bot
Copy link
Contributor

@Varal7 merged this pull request in c769300.

@Varal7 Varal7 deleted the fix_maxpool_default_pad_doc branch June 4, 2021 15:59
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
Summary:
Fixes pytorch#33384

Pull Request resolved: pytorch#59404

Reviewed By: albanD

Differential Revision: D28879049

Pulled By: Varal7

fbshipit-source-id: 03a86cd347d53ac2d06028b3f213c5b5d5ab7e91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max-pooling uses implicit negative infinity padding, not zero-padding as indicated in documentation
3 participants