Fix tensor.permute(dims) backward for negative dims #5945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pytorch#5943 For the following code: ``` import torch u = torch.zeros((3, 3), requires_grad=True) v = u.permute(-1, -2) # (1, 0) here is fine v.sum().backward() ``` during the backward pass, a std::vector is constructed as an "inverse" of the permutation. To do this, all the dims are indexed into the vector. The problem with that is that the negative dims were being indexed into the std::vector, causing undefined behavior. This PR wraps those negative dims so they're handled correctly.
colesbury
approved these changes
Mar 22, 2018
|
@zou3519 The perf test result looks really weird.. I just triggered a retest (https://ci.pytorch.org/jenkins/job/pytorch-builds/job/short-perf-test-cpu/1893/, it might still be in the queue) and we should probably see how that one goes |
|
https://ci.pytorch.org/jenkins/job/pytorch-builds/job/short-perf-test-cpu/1893/console -- well I guess it's fine now :) |
|
yeah seems like the machine was busy with other stuff at that time :/
…On Thu, Mar 22, 2018 at 3:56 PM Richard Zou ***@***.***> wrote:
https://ci.pytorch.org/jenkins/job/pytorch-builds/job/short-perf-test-cpu/1893/console
-- well I guess it's fine now :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5945 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD4Bk2xVLm8SnKh9uHcjbnpKxR-wPs3Hks5thAHUgaJpZM4S3giA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5943
For the following code:
during the backward pass, a std::vector is constructed
as an "inverse" of the permutation. To do this, all the dims
are indexed into the vector.
The problem with that is that the negative dims were being indexed
into the std::vector, causing undefined behavior. This PR wraps
those negative dims so they're handled correctly.
cc @colesbury
Test Plan
new unit test