Skip to content

Conversation

SplitInfinity
Copy link

@SplitInfinity SplitInfinity commented Jun 4, 2021

Stack from ghstack:

Summary
This commit adds a preamble to the torch.package documentation page
that explains briefly what torch.package is.

Test Plan
Continous integration.

Captura de Pantalla 2021-06-04 a la(s) 3 57 01 p  m

Differential Revision: D29050630

**Summary**
This commit adds a preamble to the `torch.package` documentation page
that explains briefly what `torch.package` is.

**Test Plan**
Continous integration.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 4, 2021

💊 CI failures summary and remediations

As of commit 8e113aa (more details on the Dr. CI page):


  • 5/5 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Windows CI (pytorch-win-vs2019-cpu-py3) / test (1/2)

Step: "Run test scripts" (full log | diagnosis details | 🔁 rerun)

2021-06-10T23:25:59.6497437Z ls: cannot access ...d/win_tmp/ci_scripts/*': No such file or directory
2021-06-10T23:25:59.5338252Z + PYTORCH_FINAL_PACKAGE_DIR=/c/926743030/build-results/
2021-06-10T23:25:59.5398201Z ++ cygpath -w /c/926743030/build-results/
2021-06-10T23:25:59.5494409Z + PYTORCH_FINAL_PACKAGE_DIR_WIN='C:\926743030\build-results\'
2021-06-10T23:25:59.5495067Z + export PYTORCH_FINAL_PACKAGE_DIR_WIN
2021-06-10T23:25:59.5495489Z + export PYTORCH_TEST_SKIP_NOARCH=1
2021-06-10T23:25:59.5495921Z + PYTORCH_TEST_SKIP_NOARCH=1
2021-06-10T23:25:59.5496446Z + mkdir -p /c/actions-runner/_work/pytorch/pytorch/build/win_tmp/build/torch
2021-06-10T23:25:59.5929471Z + CI_SCRIPTS_DIR=/c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts
2021-06-10T23:25:59.5931090Z + mkdir -p /c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts
2021-06-10T23:25:59.6132455Z ++ ls '/c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts/*'
2021-06-10T23:25:59.6497437Z ls: cannot access '/c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts/*': No such file or directory
2021-06-10T23:25:59.6500586Z + '[' -n '' ']'
2021-06-10T23:25:59.6501315Z + export SCRIPT_HELPERS_DIR=/c/actions-runner/_work/pytorch/pytorch/.jenkins/pytorch/win-test-helpers
2021-06-10T23:25:59.6502194Z + SCRIPT_HELPERS_DIR=/c/actions-runner/_work/pytorch/pytorch/.jenkins/pytorch/win-test-helpers
2021-06-10T23:25:59.6507969Z + IN_PULL_REQUEST=
2021-06-10T23:25:59.6508299Z + '[' -n '' ']'
2021-06-10T23:25:59.6508741Z + [[ pytorch-win-vs2019-cpu-py3 == *cuda11* ]]
2021-06-10T23:25:59.6509988Z + run_tests
2021-06-10T23:25:59.6510597Z + for path in '/c/Program Files/NVIDIA Corporation/NVSMI/nvidia-smi.exe' /c/Windows/System32/nvidia-smi.exe
2021-06-10T23:25:59.6511399Z + [[ -x /c/Program Files/NVIDIA Corporation/NVSMI/nvidia-smi.exe ]]
2021-06-10T23:25:59.6512037Z + '/c/Program Files/NVIDIA Corporation/NVSMI/nvidia-smi.exe'

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 11 00:44:43 test_udf_remote_message_delay...yUniqueId(created_on=0, local_id=0) to be created.
Jun 11 00:44:01 frame #13: c10::ThreadPool::main_loop(unsigned long) + 0x2a3 (0x7f445b5d3bd3 in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jun 11 00:44:01 frame #14: <unknown function> + 0xc8421 (0x7f444ffd6421 in /opt/conda/lib/libstdc++.so.6)
Jun 11 00:44:01 frame #15: <unknown function> + 0x76ba (0x7f446aa636ba in /lib/x86_64-linux-gnu/libpthread.so.0)
Jun 11 00:44:01 frame #16: clone + 0x6d (0x7f446a79951d in /lib/x86_64-linux-gnu/libc.so.6)
Jun 11 00:44:01 
Jun 11 00:44:01 ok (4.043s)
Jun 11 00:44:17   test_rpc_builtin_timeout (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (15.572s)
Jun 11 00:44:26   test_rpc_script_timeout (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (9.558s)
Jun 11 00:44:30   test_rref_to_here_timeout (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (4.043s)
Jun 11 00:44:38   test_udf_remote_message_delay_timeout (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (8.053s)
Jun 11 00:44:43   test_udf_remote_message_delay_timeout_to_self (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... [E request_callback_no_python.cpp:552] Received error while processing request type 261: falseINTERNAL ASSERT FAILED at "/var/lib/jenkins/workspace/torch/csrc/distributed/rpc/rref_context.cpp":387, please report a bug to PyTorch. Expected OwnerRRef with id GloballyUniqueId(created_on=0, local_id=0) to be created.
Jun 11 00:44:43 Exception raised from getOwnerRRef at /var/lib/jenkins/workspace/torch/csrc/distributed/rpc/rref_context.cpp:387 (most recent call first):
Jun 11 00:44:43 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x69 (0x7fd691ad4ed9 in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jun 11 00:44:43 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xd2 (0x7fd691ad0fd2 in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jun 11 00:44:43 frame #2: c10::detail::torchInternalAssertFail(char const*, char const*, unsigned int, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0x4e (0x7fd691ad296e in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jun 11 00:44:43 frame #3: torch::distributed::rpc::RRefContext::getOwnerRRef(torch::distributed::rpc::GloballyUniqueId const&, bool) + 0x4b4 (0x7fd68a63ef54 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 11 00:44:43 frame #4: torch::distributed::rpc::RequestCallbackNoPython::assignOwnerRRef(torch::distributed::rpc::GloballyUniqueId const&, torch::distributed::rpc::GloballyUniqueId const&, c10::intrusive_ptr<c10::ivalue::Future, c10::detail::intrusive_target_default_null_type<c10::ivalue::Future> >) const + 0x71 (0x7fd68a62ef71 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 11 00:44:43 frame #5: torch::distributed::rpc::RequestCallbackImpl::processPythonRemoteCall(torch::distributed::rpc::RpcCommandBase&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0xc8 (0x7fd692e35118 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_python.so)
Jun 11 00:44:43 frame #6: torch::distributed::rpc::RequestCallbackNoPython::processRpc(torch::distributed::rpc::RpcCommandBase&, torch::distributed::rpc::MessageType const&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0x194 (0x7fd68a633a44 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 11 00:44:43 frame #7: torch::distributed::rpc::RequestCallbackImpl::processRpcWithErrors(torch::distributed::rpc::RpcCommandBase&, torch::distributed::rpc::MessageType const&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0x65 (0x7fd692e34715 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_python.so)
Jun 11 00:44:43 frame #8: <unknown function> + 0x40d761a (0x7fd68a63061a in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)

3 failures not recognized by patterns:

Job Step Action
GitHub Actions Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / build Unknown 🔁 rerun
GitHub Actions Lint / clang-tidy Generate build files 🔁 rerun
GitHub Actions Windows CI (pytorch-win-vs2019-cpu-py3) / render_test_results Download PyTorch Test Reports 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

SplitInfinity pushed a commit that referenced this pull request Jun 4, 2021
**Summary**
This commit adds a preamble to the `torch.package` documentation page
that explains briefly what `torch.package` is.

**Test Plan**
Continous integration.

ghstack-source-id: af9e078
Pull Request resolved: #59491
**Summary**
This commit adds a preamble to the `torch.package` documentation page
that explains briefly what `torch.package` is.

**Test Plan**
Continous integration.

<img width="881" alt="Captura de Pantalla 2021-06-04 a la(s) 3 57 01 p  m" src="https://user-images.githubusercontent.com/4392003/120872203-d535e000-c552-11eb-841d-b38df19bc992.png">


[ghstack-poisoned]
@@ -7,6 +7,14 @@ torch.package

This module is experimental and has not yet been publicly released.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a beta message now, right?


This document contains tutorials, how-to guides, explanations, and an API reference that
will help you learn more about ``torch.package`` and how to use it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add pickle warning here as discussed

@SplitInfinity
Copy link
Author

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in a3db8e0.

@facebook-github-bot facebook-github-bot deleted the gh/splitinfinity/141/head branch June 14, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants