[c10d] Move pg wrapper tests to their own file. #59840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving these tests to their own standalone file. No meaningful code changes. Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)! [ghstack-poisoned]
rohan-varma
requested review from
cbalioglu,
H-Huang,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
💊 CI failures summary and remediationsAs of commit e33ae45 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
moving these tests to their own standalone file. No meaningful code changes. Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 10, 2021
Pull Request resolved: #59840 moving these tests to their own standalone file. No meaningful code changes. ghstack-source-id: 131140202 Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)!
cbalioglu
approved these changes
Jun 11, 2021
test/distributed/test_pg_wrapper.py
Outdated
| run_tests, | ||
| TEST_WITH_TSAN, | ||
| ) | ||
| import test_c10d_common |
There was a problem hiding this comment.
Although a minor issue, causes CI to break.
moving these tests to their own standalone file. No meaningful code changes. Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 11, 2021
Pull Request resolved: #59840 moving these tests to their own standalone file. No meaningful code changes. ghstack-source-id: 131263526 Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)!
moving these tests to their own standalone file. No meaningful code changes. Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 13, 2021
Pull Request resolved: #59840 moving these tests to their own standalone file. No meaningful code changes. ghstack-source-id: 131302351 Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)!
moving these tests to their own standalone file. No meaningful code changes. Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)! [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jun 14, 2021
Pull Request resolved: #59840 moving these tests to their own standalone file. No meaningful code changes. ghstack-source-id: 131359162 Differential Revision: [D29012664](https://our.internmc.facebook.com/intern/diff/D29012664/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D29012664/)!
|
This pull request has been merged in c209848. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
moving these tests to their own standalone file. No meaningful code changes.
Differential Revision: D29012664
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!