-
Notifications
You must be signed in to change notification settings - Fork 24.7k
ensure xml report path are relative to CI prefix #60380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 83595fb (more details on the Dr. CI page and at hud.pytorch.org/pr/60380):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Job | Step | Action |
---|---|---|
Run tests | 🔁 rerun |
🚧 1 fixed upstream failure:
These were probably caused by upstream breakages that were already fixed.
Please rebase on the viable/strict
branch (expand for instructions)
If your commit is older than viable/strict
, run these commands:
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
- pytorch_linux_bionic_rocm3_9_py3_6_build on Jun 21 from 1:29pm to 2:54pm (65f33ec - 65f33ec)
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
@@ -255,7 +255,8 @@ def chunk_list(lst, nchunks): | |||
|
|||
# sanitize filename e.g., distributed/pipeline/sync/skip/test_api.py -> distributed.pipeline.sync.skip.test_api | |||
def sanitize_test_filename(filename): | |||
strip_py = re.sub(r'.py$', '', filename) | |||
strip_py = re.sub(r'.*/pytorch/test/', '', filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strip_py = re.sub(r'.*/pytorch/test/', '', filename) | |
# Replace initial dot with underscore | |
strip_py = re.sub(r'^\.', '_', filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wouldn't work because the sanitized test file path needs to be one of those listed in
Line 31 in 1fc3e1e
TESTS = [ |
1f62b2e
to
1e44b44
Compare
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@walterddr merged this pull request in 5921b54. |
Root cause of this is for some reason:
inspect.getfile
returns absolute path instead of relative path toos.getcwd
in newer python version. we sanitize this by removing the CI_PREFIX if appliesSee:
https://app.circleci.com/pipelines/github/pytorch/pytorch/339568/workflows/43cac71c-759e-471f-83c2-d59c152dcd8a/jobs/14278585 vs. https://app.circleci.com/pipelines/github/pytorch/pytorch/339568/workflows/43cac71c-759e-471f-83c2-d59c152dcd8a/jobs/14278285
Test Plan:
CI
Plot twist:
windows tests are actually launched via
while linux/macos tests are
This might cause problem when using
os.getcwd()
we will see from PR CI results.