changed launch bounds, unrolled for loop for grid sampler 2d fwd and bwd #60405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit e0aa52e (more details on the Dr. CI page and at hud.pytorch.org/pr/60405):
1 failure not recognized by patterns:
❄️ 2 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
anjali411
added
module: cuda
ngimel
approved these changes
Jun 22, 2021
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
Summary: This PR fixes the `mypy` failure introduced by [`numpy` 1.21.0](https://github.com/numpy/numpy/releases/tag/v1.21.0) (by pinning `numpy` to 1.20, at least for now) and the `quick-checks` failure introduced by #60405. Pull Request resolved: #60472 Test Plan: The Lint workflow in GitHub Actions. Reviewed By: walterddr Differential Revision: D29313009 Pulled By: driazati fbshipit-source-id: 53fd0e0549c26be5fc5d3c502c5891c56c83a32c
jjsjann123
pushed a commit
to csarofeen/pytorch
that referenced
this pull request
Jun 23, 2021
Summary: This PR fixes the `mypy` failure introduced by [`numpy` 1.21.0](https://github.com/numpy/numpy/releases/tag/v1.21.0) (by pinning `numpy` to 1.20, at least for now) and the `quick-checks` failure introduced by pytorch#60405. Pull Request resolved: pytorch#60472 Test Plan: The Lint workflow in GitHub Actions. Reviewed By: walterddr Differential Revision: D29313009 Pulled By: driazati fbshipit-source-id: 53fd0e0549c26be5fc5d3c502c5891c56c83a32c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed launch bounds for grid sampler 2d fwd and bwd from 1024 to 256, added loop unrolling to fix register spilling into local memory.
Timing Data: (using Nvidia Titan-V)
Interpolation mode 2, padding 0, align corners False