[NormalizeArgs] Retain node.meta #60449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: After normalizing args, still retain each node's `meta` Test Plan: Added unit test. Differential Revision: D29293179 fbshipit-source-id: 974bd79b54330e4b48197889c8260c9dc00e849a
💊 CI failures summary and remediationsAs of commit 8ba9e39 (more details on the Dr. CI page and at hud.pytorch.org/pr/60449):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D29293179 |
Codecov Report
@@ Coverage Diff @@
## master #60449 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 2054 2054
Lines 205033 205034 +1
=======================================
+ Hits 156299 156305 +6
+ Misses 48734 48729 -5 |
|
CC: @jamesr66a |
|
This pull request has been merged in 7ed07e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: After normalizing args, still retain each node's
metaTest Plan: Added unit test.
Differential Revision: D29293179