Skip to content

task 3: typecheck #60805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 24 commits into from
Closed

task 3: typecheck #60805

wants to merge 24 commits into from

Conversation

migeed-z
Copy link
Contributor

@migeed-z migeed-z commented Jun 26, 2021 •
edited
Loading

@migeed-z
fix mypy errors
b51173e 
[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3e01d10 (more details on the Dr. CI page and at hud.pytorch.org/pr/60805):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jun 26, 2021
Closed
Closed
Closed
@migeed-z
Update on "fix mypy errors"
499e976 
[ghstack-poisoned]
@migeed-z
Update on "fix mypy errors"
3f16081 
[ghstack-poisoned]
@migeed-z
Update on "fix mypy errors"
1aa0460 
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jun 26, 2021
@migeed-z
fix mypy errors
ba90a85 
ghstack-source-id: cefcfd5
Pull Request resolved: #60805

fix mypy errors

ghstack-source-id: cefcfd5
Pull Request resolved: #60806

fix mypy errors

fix linting errors
@migeed-z
Update on "fix mypy errors"
f2ed9af 
[ghstack-poisoned]
@migeed-z
Update on "fix mypy errors"
e910ea6 
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jun 26, 2021
@migeed-z
fix mypy errors
d6b9d9d 
ghstack-source-id: 3f2fd18
Pull Request resolved: #60805

fix mypy errors

ghstack-source-id: 3f2fd18
Pull Request resolved: #60806

fix mypy errors

fix linting errors
@migeed-z
Update on "fix mypy errors"
03c061f 
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jun 27, 2021
@migeed-z
fix mypy errors
2befec7 
ghstack-source-id: d947923
Pull Request resolved: #60805

fix mypy errors

ghstack-source-id: d947923
Pull Request resolved: #60806

fix mypy errors

fix linting errors
@migeed-z
Update on "fix mypy errors"
a63fbf4 
[ghstack-poisoned]
@migeed-z
Update on "fix mypy errors"
e86d1df 
[ghstack-poisoned]
@migeed-z
Update on "fix mypy errors"
ce451ea 
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jun 27, 2021
@migeed-z
fix mypy errors
9daddbd 
ghstack-source-id: d835931
Pull Request resolved: #60805

fix mypy errors

ghstack-source-id: d835931
Pull Request resolved: #60806

fix mypy errors

fix linting errors
@migeed-z
Update on "fix mypy errors"
b47307e 
[ghstack-poisoned]
@migeed-z migeed-z changed the title fix mypy errors task 3: typecheck Jun 28, 2021
@migeed-z
Update on "task 3: typecheck"
7eeb1a3 
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jun 29, 2021
@migeed-z
fix mypy errors
29d06bb 
ghstack-source-id: ee5ae3e
Pull Request resolved: #60805

fix mypy errors

ghstack-source-id: ee5ae3e
Pull Request resolved: #60806

fix mypy errors

fix linting errors
@jamesr66a jamesr66a requested a review from Chillee June 29, 2021 20:34
@migeed-z
Update on "task 3: typecheck"
2ed37fd 
[ghstack-poisoned]
@migeed-z
Update on "task 3: typecheck"
af44c7d 
[ghstack-poisoned]
@migeed-z
Update on "task 3: typecheck"
88005b8 
[ghstack-poisoned]
@migeed-z
Update on "task 3: typecheck"
876e426 
[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jun 30, 2021
@migeed-z
fix mypy errors
e06b95a 
ghstack-source-id: 6cb1efe
Pull Request resolved: #60805

fix mypy errors

ghstack-source-id: 6cb1efe
Pull Request resolved: #60806

fix mypy errors

fix linting errors
@migeed-z migeed-z mentioned this pull request Jun 30, 2021
Closed
jamesr66a
jamesr66a approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@migeed-z
Update on "task 3: typecheck"
d7d7396 
[ghstack-poisoned]
@migeed-z migeed-z requested a review from jamesr66a June 30, 2021 19:57
@migeed-z migeed-z mentioned this pull request Jul 1, 2021
Closed
@migeed-z
Copy link
Contributor Author

migeed-z commented Jul 1, 2021

@migeed-z has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This was referenced Jul 1, 2021
Closed
Closed
Closed
Closed
Closed
Closed
migeed-z added 2 commits July 6, 2021 19:09
@migeed-z
Update on "task 3: typecheck"
3924d9f 
Differential Revision: [D29522885](https://our.internmc.facebook.com/intern/diff/D29522885)

[ghstack-poisoned]
@migeed-z
Update on "task 3: typecheck"
3e01d10 
Differential Revision: [D29522885](https://our.internmc.facebook.com/intern/diff/D29522885)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@migeed-z merged this pull request in 6f14554.

@facebook-github-bot facebook-github-bot deleted the gh/migeed-z/10/head branch July 10, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison Awaiting requested review from eellison

@ansley ansley Awaiting requested review from ansley

@Chillee Chillee Awaiting requested review from Chillee

@jamesr66a jamesr66a Awaiting requested review from jamesr66a

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@migeed-z @facebook-github-bot @jamesr66a