Fix fx patch module name #61062
Closed
Fix fx patch module name #61062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of being 'patch' this should be the import-able name of the module (it's defined as `_fx` on the `torch._C` module, so the full name should be `torch._C._fx`). This now works correctly: ```python >>> import torch._C._fx >>> dir(torch._C._fx) ['__doc__', '__loader__', '__name__', '__package__', '__spec__', 'patch_function'] ``` [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit f9cb8aa (more details on the Dr. CI page and at hud.pytorch.org/pr/61062):
Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Chillee
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Instead of being 'patch' this should be the import-able name of the module (it's defined as
_fxon thetorch._Cmodule, so the full name should betorch._C._fx). This now works correctly:Differential Revision: D29497018