Skip to content

OpInfo: bitwise_and #61349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

OpInfo: bitwise_and #61349

wants to merge 3 commits into from

Conversation

Freey0
Copy link
Contributor

@Freey0 Freey0 commented Jul 7, 2021

Stack from ghstack:

Also add type promotion test for bugs found by pr #60813

Differential Revision: D29592840

Also add type promotion test for bugs found by pr #60813

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 7, 2021

💊 CI failures summary and remediations

As of commit d31d9ab (more details on the Dr. CI page and at hud.pytorch.org/pr/61349):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_build (1/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jul 15 13:21:21 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory
Jul 15 13:21:21 ++++ extract_trap_cmd
Jul 15 13:21:21 ++++ printf '%s\n' ''
Jul 15 13:21:21 +++ printf '%s\n' cleanup
Jul 15 13:21:21 ++ trap -- '
Jul 15 13:21:21 cleanup' EXIT
Jul 15 13:21:21 ++ [[ pytorch-linux-xenial-cuda11.1-cudnn8-py3-gcc7-build != *pytorch-win-* ]]
Jul 15 13:21:21 ++ which sccache
Jul 15 13:21:21 ++ sccache --stop-server
Jul 15 13:21:21 ++ true
Jul 15 13:21:21 ++ rm /var/lib/jenkins/sccache_error.log
Jul 15 13:21:21 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory
Jul 15 13:21:21 ++ true
Jul 15 13:21:21 ++ [[ -n '' ]]
Jul 15 13:21:21 ++ [[ pytorch-linux-xenial-cuda11.1-cudnn8-py3-gcc7-build == *rocm* ]]
Jul 15 13:21:21 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Jul 15 13:21:21 ++ SCCACHE_IDLE_TIMEOUT=1200
Jul 15 13:21:21 ++ RUST_LOG=sccache::server=error
Jul 15 13:21:21 ++ sccache --start-server
Jul 15 13:21:21 sccache: Starting the server...
Jul 15 13:21:21 ++ sccache --zero-stats
Jul 15 13:21:21 Compile requests                      0

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 15 16:30:37 AssertionError: RuntimeError not raised by
Jul 15 16:30:37 test_random_from_to_bool (__main__.TestRandom) ... ok
Jul 15 16:30:37 test_get_xla_tensor (__main__.TestSelect) ... ok
Jul 15 16:30:37 test (__main__.TestToXlaTensorArena) ... ok
Jul 15 16:30:37 
Jul 15 16:30:37 ======================================================================
Jul 15 16:30:37 FAIL: test_pred_type (__main__.TestAtenXlaTensor)
Jul 15 16:30:37 ----------------------------------------------------------------------
Jul 15 16:30:37 Traceback (most recent call last):
Jul 15 16:30:37   File "/var/lib/jenkins/workspace/xla/test/test_operations.py", line 1208, in test_pred_type
Jul 15 16:30:37     self.assertRaises(RuntimeError, lambda: c & c.byte())
Jul 15 16:30:37 AssertionError: RuntimeError not raised by <lambda>
Jul 15 16:30:37 
Jul 15 16:30:37 ----------------------------------------------------------------------
Jul 15 16:30:37 Ran 124 tests in 62.588s
Jul 15 16:30:37 
Jul 15 16:30:37 FAILED (failures=1)
Jul 15 16:30:37 + cleanup
Jul 15 16:30:37 + retcode=1
Jul 15 16:30:37 + set +x
Jul 15 16:30:37 =================== sccache compilation log ===================
Jul 15 16:30:37 =========== If your build fails, please take a look at the log above for possible reasons ===========

1 job timed out:

  • pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_build

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ezyang
Copy link
Contributor

ezyang commented Jul 7, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Freey0 Freey0 requested review from mruberry and ezyang July 8, 2021 12:04
@mruberry
Copy link
Collaborator

mruberry commented Jul 8, 2021

Failures are unrelated - would you just switch the sample input function to the generic binary elementwise sample inputs?

Thanks for the OpInfo, @Freey0!

Also add type promotion test for bugs found by pr #60813

Differential Revision: [D29592840](https://our.internmc.facebook.com/intern/diff/D29592840)

[ghstack-poisoned]
Freey0 added a commit that referenced this pull request Jul 10, 2021
Also add type promotion test for bugs found by pr #60813

ghstack-source-id: 32d2e4e
Pull Request resolved: #61349
@ezyang
Copy link
Contributor

ezyang commented Jul 12, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also add type promotion test for bugs found by pr #60813

Differential Revision: [D29592840](https://our.internmc.facebook.com/intern/diff/D29592840)

[ghstack-poisoned]
Freey0 added a commit that referenced this pull request Jul 15, 2021
Also add type promotion test for bugs found by pr #60813

ghstack-source-id: 59ed7fd
Pull Request resolved: #61349
@ezyang
Copy link
Contributor

ezyang commented Jul 19, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 109bd5e.

@facebook-github-bot facebook-github-bot deleted the gh/Feey0/39/head branch July 25, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants