[package] properly handle case where we are re-packaging mocked modules #61434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocking is the only time we introduce a "special" module to a torch.package of our own creation. This interacts poorly with re-packaging, since if we treat `_mock` as a regular module and try to package it normally we will produce a broken package. This PR teaches PackageExporter to recognize `_mock` modules and treat them specially during the dependency walking process, thus avoiding the issue. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit ecc8cc2 (more details on the Dr. CI page and at hud.pytorch.org/pr/61434): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
suo
added a commit
that referenced
this pull request
Jul 8, 2021
Mocking is the only time we introduce a "special" module to a torch.package of our own creation. This interacts poorly with re-packaging, since if we treat `_mock` as a regular module and try to package it normally we will produce a broken package. This PR teaches PackageExporter to recognize `_mock` modules and treat them specially during the dependency walking process, thus avoiding the issue. ghstack-source-id: 8a42340 Pull Request resolved: #61434
…ocked modules" Mocking is the only time we introduce a "special" module to a torch.package of our own creation. This interacts poorly with re-packaging, since if we treat `_mock` as a regular module and try to package it normally we will produce a broken package. This PR teaches PackageExporter to recognize `_mock` modules and treat them specially during the dependency walking process, thus avoiding the issue. [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jul 9, 2021
Mocking is the only time we introduce a "special" module to a torch.package of our own creation. This interacts poorly with re-packaging, since if we treat `_mock` as a regular module and try to package it normally we will produce a broken package. This PR teaches PackageExporter to recognize `_mock` modules and treat them specially during the dependency walking process, thus avoiding the issue. ghstack-source-id: ff79a16 Pull Request resolved: #61434
|
@suo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Mocking is the only time we introduce a "special" module to a
torch.package of our own creation. This interacts poorly with
re-packaging, since if we treat
_mockas a regular module and try topackage it normally we will produce a broken package.
This PR teaches PackageExporter to recognize
_mockmodules and treatthem specially during the dependency walking process, thus avoiding the
issue.
Differential Revision: D29638283