Use better defaults in the clang-tidy wrapper script #61651

1ntEgr8 · 2021-07-14T15:05:46Z

Stack from ghstack:

This PR sets some QOL defaults to the clang-tidy wrapper script and refactors how defaults are set.

Runs in parallel
Custom executable (prints an error message to users asking them to install our custom build)
generate_build_files can now be run as a script

Differential Revision: D29743661

[ghstack-poisoned]

facebook-github-bot · 2021-07-14T15:05:52Z

💊 CI failures summary and remediations

As of commit bf0d421 (more details on the Dr. CI page and at hud.pytorch.org/pr/61651):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jul 16 04:50:07 test_remote_message_script_de...yUniqueId(created_on=0, local_id=0) to be created.

Jul 16 04:49:39 frame #12: std::__1::__function::__func<std::__1::__bind<torch::distributed::rpc::ProcessGroupAgent::enqueueRecv(torch::distributed::rpc::RecvWork)::$_6, torch::distributed::rpc::RecvWork>, std::__1::allocator<std::__1::__bind<torch::distributed::rpc::ProcessGroupAgent::enqueueRecv(torch::distributed::rpc::RecvWork)::$_6, torch::distributed::rpc::RecvWork> >, void ()>::operator()() + 42 (0x11a47547a in libtorch_cpu.dylib)
Jul 16 04:49:39 frame #13: c10::ThreadPool::main_loop(unsigned long) + 569 (0x114bf1369 in libc10.dylib)
Jul 16 04:49:39 frame #14: void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, c10::ThreadPool::ThreadPool(int, int, std::__1::function<void ()>)::$_0> >(void*) + 67 (0x114bf1a13 in libc10.dylib)
Jul 16 04:49:39 frame #15: _pthread_start + 148 (0x7fff70e4d109 in libsystem_pthread.dylib)
Jul 16 04:49:39 frame #16: thread_start + 15 (0x7fff70e48b8b in libsystem_pthread.dylib)
Jul 16 04:49:39 
Jul 16 04:49:39 ok (3.931s)
Jul 16 04:49:48   test_remote_message_dropped_pickle (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (8.158s)
Jul 16 04:49:56   test_remote_message_dropped_pickle_to_self (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (8.488s)
Jul 16 04:50:03   test_remote_message_script_delay_timeout (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... ok (6.950s)
Jul 16 04:50:07   test_remote_message_script_delay_timeout_to_self (__main__.FaultyFaultyAgentRpcTestWithSpawn) ... [E request_callback_no_python.cpp:555] Received error while processing request type 260: falseINTERNAL ASSERT FAILED at "../torch/csrc/distributed/rpc/rref_context.cpp":390, please report a bug to PyTorch. Expected OwnerRRef with id GloballyUniqueId(created_on=0, local_id=0) to be created.
Jul 16 04:50:07 Exception raised from getOwnerRRef at ../torch/csrc/distributed/rpc/rref_context.cpp:390 (most recent call first):
Jul 16 04:50:07 frame #0: c10::Error::Error(c10::SourceLocation, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >) + 98 (0x1100136b2 in libc10.dylib)
Jul 16 04:50:07 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 106 (0x110011e2a in libc10.dylib)
Jul 16 04:50:07 frame #2: c10::detail::torchInternalAssertFail(char const*, char const*, unsigned int, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 64 (0x110012060 in libc10.dylib)
Jul 16 04:50:07 frame #3: torch::distributed::rpc::RRefContext::getOwnerRRef(torch::distributed::rpc::GloballyUniqueId const&, bool) + 1711 (0x11cd5997f in libtorch_cpu.dylib)
Jul 16 04:50:07 frame #4: torch::distributed::rpc::RequestCallbackNoPython::assignOwnerRRef(torch::distributed::rpc::GloballyUniqueId const&, torch::distributed::rpc::GloballyUniqueId const&, c10::intrusive_ptr<c10::ivalue::Future, c10::detail::intrusive_target_default_null_type<c10::ivalue::Future> >) const + 86 (0x11cd441d6 in libtorch_cpu.dylib)
Jul 16 04:50:07 frame #5: torch::distributed::rpc::RequestCallbackImpl::processScriptRemoteCall(torch::distributed::rpc::RpcCommandBase&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const + 376 (0x10f6107c8 in libtorch_python.dylib)
Jul 16 04:50:07 frame #6: torch::distributed::rpc::RequestCallbackNoPython::processRpc(torch::distributed::rpc::RpcCommandBase&, torch::distributed::rpc::MessageType const&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const + 437 (0x11cd42e25 in libtorch_cpu.dylib)
Jul 16 04:50:07 frame #7: torch::distributed::rpc::RequestCallbackImpl::processRpcWithErrors(torch::distributed::rpc::RpcCommandBase&, torch::distributed::rpc::MessageType const&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const + 74 (0x10f61153a in libtorch_python.dylib)
Jul 16 04:50:07 frame #8: c10::intrusive_ptr<c10::ivalue::Future, c10::detail::intrusive_target_default_null_type<c10::ivalue::Future> > c10::ivalue::Future::thenAsync<torch::distributed::rpc::RequestCallbackNoPython::processMessage(torch::distributed::rpc::Message&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const::$_1>(torch::distributed::rpc::RequestCallbackNoPython::processMessage(torch::distributed::rpc::Message&, std::__1::vector<c10::Stream, std::__1::allocator<c10::Stream> >) const::$_1, std::__1::shared_ptr<c10::Type>)::'lambda'(c10::ivalue::Future&)::operator()(c10::ivalue::Future&) + 223 (0x11cd4aaef in libtorch_cpu.dylib)

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ghstack-source-id: f82e7a5 Pull Request resolved: #61651

This PR sets some QOL defaults to the clang-tidy wrapper script and refactors how defaults are set. - Runs in parallel - Custom executable (prints an error message to users asking them to install our custom build) [ghstack-poisoned]

tools/linter/clang_tidy/__main__.py

.github/workflows/lint.yml

This PR sets some QOL defaults to the clang-tidy wrapper script and refactors how defaults are set. - Runs in parallel - Custom executable (prints an error message to users asking them to install our custom build) - `generate_build_files` can now be run as a script [ghstack-poisoned]

tools/linter/clang_tidy/__main__.py

This PR sets some QOL defaults to the clang-tidy wrapper script and refactors how defaults are set. - Runs in parallel - Custom executable (prints an error message to users asking them to install our custom build) - `generate_build_files` can now be run as a script [ghstack-poisoned]

1ntEgr8 · 2021-07-16T21:29:17Z

@1ntEgr8 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-07-16T22:00:38Z

@1ntEgr8 merged this pull request in 7ac8054.

ghstack-source-id: f8a4873 Pull Request resolved: pytorch/pytorch#61651

Use better defaults in the clang-tidy wrapper script

fa99c10

[ghstack-poisoned]

facebook-github-bot added the cla signed label Jul 14, 2021

1ntEgr8 added a commit that referenced this pull request Jul 14, 2021

Use better defaults in the clang-tidy wrapper script

ed6abb4

ghstack-source-id: f82e7a5 Pull Request resolved: #61651

1ntEgr8 mentioned this pull request Jul 14, 2021

Update progress and error reporting in clang-tidy #61672

Closed

1ntEgr8 added 5 commits July 14, 2021 12:35

1ntEgr8 mentioned this pull request Jul 14, 2021

Remove ninja related code from clang-tidy script #61673

Closed

1ntEgr8 requested review from driazati, janeyx99 and samestep July 14, 2021 20:17

This was referenced Jul 14, 2021

[do not merge] Test clang-tidy #61674

Closed

Enable clang-tidy on master #61689

Closed

driazati approved these changes Jul 15, 2021

View reviewed changes

tools/linter/clang_tidy/__main__.py Outdated Show resolved Hide resolved

.github/workflows/lint.yml Outdated Show resolved Hide resolved

1ntEgr8 mentioned this pull request Jul 15, 2021

Add script to generate token-count stats #61711

Closed

janeyx99 approved these changes Jul 15, 2021

View reviewed changes

tools/linter/clang_tidy/__main__.py Outdated Show resolved Hide resolved

facebook-github-bot closed this in 7ac8054 Jul 16, 2021

facebook-github-bot added the Merged label Jul 16, 2021

facebook-github-bot deleted the gh/1ntEgr8/15/head branch July 20, 2021 14:16

QYP-842653 pushed a commit to QYP-842653/Pytorch that referenced this pull request Jul 27, 2021

Use better defaults in the clang-tidy wrapper script

f4528c9

ghstack-source-id: f8a4873 Pull Request resolved: pytorch/pytorch#61651

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use better defaults in the clang-tidy wrapper script #61651

Use better defaults in the clang-tidy wrapper script #61651

Uh oh!

1ntEgr8 commented Jul 14, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Jul 14, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

1ntEgr8 commented Jul 16, 2021

Uh oh!

facebook-github-bot commented Jul 16, 2021

Uh oh!

Uh oh!

Use better defaults in the clang-tidy wrapper script #61651

Use better defaults in the clang-tidy wrapper script #61651

Uh oh!

Conversation

1ntEgr8 commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jul 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_macos_10_13_py3_test (1/1)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

1ntEgr8 commented Jul 16, 2021

Uh oh!

facebook-github-bot commented Jul 16, 2021

Uh oh!

Uh oh!

1ntEgr8 commented Jul 14, 2021 •

edited

Loading

facebook-github-bot commented Jul 14, 2021 •

edited

Loading