Disable avoid-non-const-global-variables lint check
#62008
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
requested review from
albanD,
BowenBao,
cbalioglu,
H-Huang,
mingzhe09088,
mrshenli,
neginraoof,
pritamdamania87,
rohan-varma,
wayi1,
soulitzer and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 11e3c5c (more details on the Dr. CI page and at hud.pytorch.org/pr/62008): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: jit
malfet
added
module: lint
malfet
force-pushed
the
malfet/disable-cppcoreguidelines-avoid-non-const-global-variables
branch
from
fa310fd to
1e41ff0
Compare
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
driazati
approved these changes
Jul 22, 2021
malfet
force-pushed
the
malfet/disable-cppcoreguidelines-avoid-non-const-global-variables
branch
from
1e41ff0 to
11e3c5c
Compare
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
deleted the
malfet/disable-cppcoreguidelines-avoid-non-const-global-variables
branch
jjsjann123
pushed a commit
to jjsjann123/nvfuser
that referenced
this pull request
Oct 29, 2022
Summary: As GoogleTest `TEST` macro is non-compliant with it as well as `DEFINE_DISPATCH` All changes but the ones to `.clang-tidy` are generated using following script: ``` for i in `find . -type f -iname "*.c*" -or -iname "*.h"|xargs grep cppcoreguidelines-avoid-non-const-global-variables|cut -f1 -d:|sort|uniq`; do sed -i "/\/\/ NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)/d" $i; done ``` Pull Request resolved: pytorch/pytorch#62008 Reviewed By: driazati, r-barnes Differential Revision: D29838584 Pulled By: malfet fbshipit-source-id: 1b2f8602c945bd4ce50a9bfdd204755556e31d13
jjsjann123
pushed a commit
to jjsjann123/nvfuser
that referenced
this pull request
Nov 10, 2022
Summary: As GoogleTest `TEST` macro is non-compliant with it as well as `DEFINE_DISPATCH` All changes but the ones to `.clang-tidy` are generated using following script: ``` for i in `find . -type f -iname "*.c*" -or -iname "*.h"|xargs grep cppcoreguidelines-avoid-non-const-global-variables|cut -f1 -d:|sort|uniq`; do sed -i "/\/\/ NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)/d" $i; done ``` Pull Request resolved: pytorch/pytorch#62008 Reviewed By: driazati, r-barnes Differential Revision: D29838584 Pulled By: malfet fbshipit-source-id: 1b2f8602c945bd4ce50a9bfdd204755556e31d13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As GoogleTest
TESTmacro is non-compliant with it as well asDEFINE_DISPATCHAll changes but the ones to
.clang-tidyare generated using following script: