-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Enable macos clang-tidy installs #62214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c54caa9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
I ran it locally, and got:
which I believe is correct. |
@1ntEgr8 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@1ntEgr8 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM either way on instructions
git diff HEAD~1 > pr.diff | ||
python tools/linter/clang_tidy --paths torch/csrc --diff-file "pr.diff" | ||
``` | ||
1. Install clang-tidy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the Makefile below and these are encoded in make setup_lint
, should we suggest that here instead of running the steps manually? It installs some other packages for the other linters but devs probably want those anyways
This PR enables installing our custom MacOS clang-tidy binaries. It also updates related documentation.
The binaries are produced by this CI job, and are published to S3.
This PR does not handle versioning of the downloaded binaries as this is being worked on separately. See pytorch/test-infra#73
Test Plan:
On a MacOS machine, run