Skip to content

Enable Profile-Directed Typing in torch.jit.script #62420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Enable Profile-Directed Typing in torch.jit.script #62420

wants to merge 4 commits into from

Conversation

nikithamalgifb
Copy link
Contributor

@nikithamalgifb nikithamalgifb commented Jul 29, 2021 •
edited
Loading

Merge torch.jit.script and torch.jit._script_pdt API. This PR merges profile directed typing with script api

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 29, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 1987994 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 29, 2021
@nikithamalgifb nikithamalgifb force-pushed the merge_script_pdt_api branch 2 times, most recently from 4ee2ac6 to 4041da5 Compare July 29, 2021 17:51
@nikithamalgifb nikithamalgifb marked this pull request as ready for review July 29, 2021 20:26
@nikithamalgifb nikithamalgifb requested a review from gmagogsfm July 29, 2021 20:27
@gmagogsfm
Copy link
Contributor

Should we consider finishing all the clean ups before merging APIs?

@nikithamalgifb
Copy link
Contributor Author

Should we consider finishing all the clean ups before merging APIs?

I don't think we should wait. Because the clean ups are independent of the API merge. They should not be affected.

gmagogsfm
gmagogsfm approved these changes Aug 23, 2021
View reviewed changes
torch/jit/_script.py Outdated
for examples in example_inputs:
obj(*examples)
else:
warnings.warn("Error: Unable to infer types. Please format the inputs to type `List[Tuple]`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing these warnings into errors because these errors would make torch.jit.script not perform what the caller is asking for

@facebook-github-bot
Copy link
Contributor

@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #62420 (1987994) into master (aeec177) will decrease coverage by 0.05%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##           master   #62420      +/-   ##
==========================================
- Coverage   66.79%   66.74%   -0.06%     
==========================================
  Files         695      695              
  Lines       90833    90823      -10     
==========================================
- Hits        60670    60617      -53     
- Misses      30163    30206      +43

@facebook-github-bot
Copy link
Contributor

@nikithamalgifb merged this pull request in 510d2ec.

@tugsbayasgalan tugsbayasgalan changed the title Merge script and _script_pdt API Enable Profile-Directed Typing in torch.jit.script Oct 18, 2021
@github-actions github-actions bot deleted the merge_script_pdt_api branch February 13, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmagogsfm gmagogsfm gmagogsfm approved these changes

Assignees
No one assigned
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikithamalgifb @facebook-github-bot @gmagogsfm