To add Rprop documentation #63866
Closed
To add Rprop documentation #63866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1bf12e5 (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
iramazanli
force-pushed
the
rprop_algorithm_doc
branch
2 times, most recently
from
e5a2a98 to
72d1b62
Compare
Codecov Report
@@ Coverage Diff @@
## master #63866 +/- ##
==========================================
- Coverage 66.84% 66.74% -0.11%
==========================================
Files 695 698 +3
Lines 90736 90881 +145
==========================================
+ Hits 60656 60658 +2
- Misses 30080 30223 +143 |
iramazanli
force-pushed
the
rprop_algorithm_doc
branch
7 times, most recently
from
739b5ca to
d030bdb
Compare
iramazanli
force-pushed
the
rprop_algorithm_doc
branch
2 times, most recently
from
c755bbb to
e6a3eaa
Compare
albanD
reviewed
Sep 7, 2021
torch/optim/rprop.py
Outdated
| &\rule{110mm}{0.4pt} \\ | ||
| &\textbf{input} : \theta_0 \in \mathbf{R}^d \text{ (params)},f(\theta) | ||
| \text{ (objective)}, \\ | ||
| &\hspace{13mm} \eta_{+/-} \text{ (etaplus, etaminus)}, \Gamma_{plus/minus} |
There was a problem hiding this comment.
This is missing initialization for g_{prev} no?
torch/optim/rprop.py
Outdated
| &\textbf{input} : \theta_0 \in \mathbf{R}^d \text{ (params)},f(\theta) | ||
| \text{ (objective)}, \\ | ||
| &\hspace{13mm} \eta_{+/-} \text{ (etaplus, etaminus)}, \Gamma_{plus/minus} | ||
| \text{ (boundaries for lr)} \\[-1.ex] |
There was a problem hiding this comment.
Is that the "step_sizes" argumeents?
There was a problem hiding this comment.
It should be mentioned explicitly then.
| \text{ (objective)}, \\ | ||
| &\hspace{13mm} \eta_{+/-} \text{ (etaplus, etaminus)}, \Gamma_{plus/minus} | ||
| \text{ (boundaries for lr)} \\[-1.ex] | ||
| &\rule{110mm}{0.4pt} \\ |
There was a problem hiding this comment.
Also \eta_t initialization is missing no?
iramazanli
force-pushed
the
rprop_algorithm_doc
branch
from
e6a3eaa to
7199546
Compare
albanD
reviewed
Sep 9, 2021
iramazanli
force-pushed
the
rprop_algorithm_doc
branch
from
7199546 to
1bf12e5
Compare
albanD
approved these changes
Sep 10, 2021
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@iramazanli merged this pull request in 54b72a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been discussed before that adding description of Optimization algorithms to PyTorch Core documentation may result in a nice Optimization research tutorial. In the following tracking issue we mentioned about all the necessary algorithms and links to the originally published paper #63236.
In this PR we are adding description of Rprop to the documentation. For more details, we refer to the paper http://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.21.1417