clarify implementation of check_grad_usage #64439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean [ghstack-poisoned]
This was referenced Sep 2, 2021
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5bc5c35 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean Differential Revision: [D30733904](https://our.internmc.facebook.com/intern/diff/D30733904) [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean Differential Revision: [D30733904](https://our.internmc.facebook.com/intern/diff/D30733904) [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean Differential Revision: [D30733904](https://our.internmc.facebook.com/intern/diff/D30733904) [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean Differential Revision: [D30733904](https://our.internmc.facebook.com/intern/diff/D30733904) [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean Differential Revision: [D30733904](https://our.internmc.facebook.com/intern/diff/D30733904) [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1) remove unused fully_implemented 2) rename used_grad to uses_grad and make it a boolean 3) rename used_grads to num_grads_uses 4) add comments explaining what some of the checks mean Differential Revision: [D30733904](https://our.internmc.facebook.com/intern/diff/D30733904) [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D30733904