Add back the owning_module fix #65159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This was a legit fix originally introduced in D30905949 (pytorch@446d95a). But we hesitated and removed it for some reason. Putting it back. Differential Revision: D30996277 fbshipit-source-id: a9627a3dfff9a3e5fe0e66579e63c32d409849fe
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3f04c1a (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D30996277 |
Codecov Report
@@ Coverage Diff @@
## master #65159 +/- ##
==========================================
+ Coverage 61.83% 66.36% +4.53%
==========================================
Files 730 730
Lines 93548 93605 +57
==========================================
+ Hits 57847 62124 +4277
+ Misses 35701 31481 -4220 |
|
This pull request has been merged in 8c38d14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This was a legit fix originally introduced in D30905949 (446d95a). But we hesitated and removed it for some reason. Putting it back.
Differential Revision: D30996277