Migrate THCAtomics to ATen #65470
Closed
Migrate THCAtomics to ATen #65470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c5cf8d5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Sep 22, 2021
peterbell10
added
module: porting
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Sep 22, 2021
[ghstack-poisoned]
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ngimel
approved these changes
Sep 23, 2021
|
A lot of other projects (e.g. vision and fbgemm_gpu) directly include THC/THCAtomics.cuh, can we temporarily restore it (and make it just include <ATen/cuda/Atomic.cuh>) until we can fix those projects to include ATen/cuda/Atomic.cuh? |
This PR already does that :) some |
|
Oh, great, didn't notice that. There are still internal breakages related to the new include that I thought were caused by file removal, but apparently not, I'll try to figure out what's going on (something about hipify, the error is which indicates that THCAtomics is hipified, but the paths in the ATen are not? |
Differential Revision: [D31148184](https://our.internmc.facebook.com/intern/diff/D31148184) [ghstack-poisoned]
|
Trying a tentative fix |
|
Yeah, just removing manual hipification is better, and rocm is passing. |
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
peterbell10
added a commit
to peterbell10/vision
that referenced
this pull request
Sep 24, 2021
THC is being removed, and this header now lives in ATen. See pytorch/pytorch#65470.
peterbell10
added a commit
to peterbell10/vision
that referenced
this pull request
Sep 24, 2021
THC is being removed, and this header now lives in ATen. See pytorch/pytorch#65470.
datumbox
added a commit
to pytorch/vision
that referenced
this pull request
Sep 27, 2021
* Update gpu atomics include path THC is being removed, and this header now lives in ATen. See pytorch/pytorch#65470. * Empty commit to trigger build Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
facebook-github-bot
pushed a commit
to pytorch/vision
that referenced
this pull request
Sep 30, 2021
Summary: * Update gpu atomics include path THC is being removed, and this header now lives in ATen. See pytorch/pytorch#65470. * Empty commit to trigger build Reviewed By: datumbox Differential Revision: D31268022 fbshipit-source-id: 880981b5b4390a6853fe0061cd9a3be0afa733e7 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
husthyc
added a commit
to pytorch/vision
that referenced
this pull request
Oct 22, 2021
* Update gpu atomics include path THC is being removed, and this header now lives in ATen. See pytorch/pytorch#65470. * Empty commit to trigger build Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> [ghstack-poisoned]
husthyc
added a commit
to pytorch/vision
that referenced
this pull request
Oct 22, 2021
* Update gpu atomics include path THC is being removed, and this header now lives in ATen. See pytorch/pytorch#65470. * Empty commit to trigger build Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> [ghstack-poisoned]
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Update gpu atomics include path THC is being removed, and this header now lives in ATen. See pytorch/pytorch#65470. * Empty commit to trigger build Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D31148184