slow_conv3d grad_weight: call gemm directly #65759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This was referenced Sep 28, 2021
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5785ca0 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced Sep 28, 2021
[ghstack-poisoned]
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D31257873](https://our.internmc.facebook.com/intern/diff/D31257873) [ghstack-poisoned]
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D31257873](https://our.internmc.facebook.com/intern/diff/D31257873) [ghstack-poisoned]
Differential Revision: [D31257873](https://our.internmc.facebook.com/intern/diff/D31257873) [ghstack-poisoned]
ngimel
reviewed
Oct 4, 2021
| const int64_t ldc = m; | ||
|
|
||
| for (int64_t group = 0; group < groups; ++group) { | ||
| at::native::cpublas::gemm( |
There was a problem hiding this comment.
same here, we probably need bmm path.
Differential Revision: [D31257873](https://our.internmc.facebook.com/intern/diff/D31257873) [ghstack-poisoned]
Differential Revision: [D31257873](https://our.internmc.facebook.com/intern/diff/D31257873) [ghstack-poisoned]
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ngimel
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D31257873