Mild refactor of native_functions.yaml dispatch parsing #66109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Closed
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1d7d5f6 (more details on the Dr. CI page):
2 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D31385760](https://our.internmc.facebook.com/intern/diff/D31385760) [ghstack-poisoned]
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyangfb.com> Differential Revision: [D31385760](https://our.internmc.facebook.com/intern/diff/D31385760) [ghstack-poisoned]
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
bdhirsh
approved these changes
Oct 14, 2021
This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyangfb.com> Differential Revision: [D31385760](https://our.internmc.facebook.com/intern/diff/D31385760) [ghstack-poisoned]
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyangfb.com> Differential Revision: [D31385760](https://our.internmc.facebook.com/intern/diff/D31385760) [ghstack-poisoned]
This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyangfb.com> Differential Revision: [D31385760](https://our.internmc.facebook.com/intern/diff/D31385760) [ghstack-poisoned]
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyangfb.com> Differential Revision: [D31385760](https://our.internmc.facebook.com/intern/diff/D31385760) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: #66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc
|
Hey @ezyang. |
ezyang
added
release notes: composability
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 21, 2022
Summary: Pull Request resolved: pytorch/pytorch#66109 This refactor is no longer necessary for ufunc codegen, as I changed the format of ufuncs to not directly be inserted into the 'dispatch' key, but I think the refactored code here is better. The basic concept is to directly construct BackendMetadata as we are parsing entries of the dispatch dictionary, rather than post facto creating them later. This centralizes the compute and means that the creation of the backend index is just a simple reindexing by operator name (nothing nontrivial). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D31385760 Pulled By: ezyang fbshipit-source-id: 4fcb491ba025d2aa6fd356586b57affb97a507fc (cherry picked from commit 21c93d41996120697f81168650b4f4b999d6902a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This refactor is no longer necessary for ufunc codegen, as I changed
the format of ufuncs to not directly be inserted into the 'dispatch'
key, but I think the refactored code here is better. The basic concept
is to directly construct BackendMetadata as we are parsing entries of
the dispatch dictionary, rather than post facto creating them later.
This centralizes the compute and means that the creation of the backend index
is just a simple reindexing by operator name (nothing nontrivial).
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D31385760