dbr quant: move model level utils into own file #68346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Some utility functions for DBR quant need to be aware of `AutoQuantizationState`. This PR moves them into their own file, so they can use the type directly without circular imports, and removes the mypy ignores which are no longer necessary after this change. Test plan: ``` python test/test_quantization.py TestQuantizeDBR ``` [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This was referenced Nov 15, 2021
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b48d191 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Nov 15, 2021
This was referenced Nov 16, 2021
Summary: Some utility functions for DBR quant need to be aware of `AutoQuantizationState`. This PR moves them into their own file, so they can use the type directly without circular imports, and removes the mypy ignores which are no longer necessary after this change. Test plan: ``` python test/test_quantization.py TestQuantizeDBR ``` [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
Nov 17, 2021
Summary: Some utility functions for DBR quant need to be aware of `AutoQuantizationState`. This PR moves them into their own file, so they can use the type directly without circular imports, and removes the mypy ignores which are no longer necessary after this change. Test plan: ``` python test/test_quantization.py TestQuantizeDBR ``` Differential Revision: [D32463763](https://our.internmc.facebook.com/intern/diff/D32463763) [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Some utility functions for DBR quant need to be aware of `AutoQuantizationState`. This PR moves them into their own file, so they can use the type directly without circular imports, and removes the mypy ignores which are no longer necessary after this change. Test plan: ``` python test/test_quantization.py TestQuantizeDBR ``` Differential Revision: [D32463763](https://our.internmc.facebook.com/intern/diff/D32463763) [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Some utility functions for DBR quant need to be aware of `AutoQuantizationState`. This PR moves them into their own file, so they can use the type directly without circular imports, and removes the mypy ignores which are no longer necessary after this change. Test plan: ``` python test/test_quantization.py TestQuantizeDBR ``` Differential Revision: [D32463763](https://our.internmc.facebook.com/intern/diff/D32463763) [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Some utility functions for DBR quant need to be aware of `AutoQuantizationState`. This PR moves them into their own file, so they can use the type directly without circular imports, and removes the mypy ignores which are no longer necessary after this change. Test plan: ``` python test/test_quantization.py TestQuantizeDBR ``` Differential Revision: [D32463763](https://our.internmc.facebook.com/intern/diff/D32463763) [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
op_convert_before_hook#68371 dbr quant overhead[6/x]: remove unneeded isinstance checks inop_convert_before_hookget_quantized_opto only useseen_op_info#68342 dbr quant: refactorget_quantized_opto only useseen_op_infoget_func_output_obs_typeto only useseen_op_info#68341 dbr quant: refactorget_func_output_obs_typeto only useseen_op_infoSummary:
Some utility functions for DBR quant need to be aware
of
AutoQuantizationState. This PR moves them into their own file, so theycan use the type directly without circular imports, and removes the mypy
ignores which are no longer necessary after this change.
Test plan:
Differential Revision: D32463763