AdaptiveLogSoftmaxWithLoss no_batch_dim support #69054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e54a712 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
george-qi
commented
Nov 30, 2021
george-qi
commented
Nov 30, 2021
jbschlosser
reviewed
Nov 30, 2021
Comment on lines
+11354
to
+11360
| # test no_batch_dim support | ||
| asfm = nn.AdaptiveLogSoftmaxWithLoss(16, 20, [5, 10, 15], div_value=2.) | ||
| x = torch.randn(1, 16) | ||
| y = torch.tensor([17]) | ||
| x2 = x.squeeze(0) | ||
| y2 = y.squeeze(0) | ||
| self.assertEqual(asfm(x, y).output.squeeze(0), asfm(x2, y2).output) |
There was a problem hiding this comment.
Thanks for adding the tests! Note that there is some precedent for using a reference function alongside the old style dictionary-based tests (see here for an example).
It won't work directly here because this module returns multiple outputs, but perhaps this can be made a bit more consistent with what's been done before
jbschlosser
reviewed
Nov 30, 2021
[ghstack-poisoned]
jbschlosser
reviewed
Dec 13, 2021
jbschlosser
reviewed
Dec 13, 2021
jbschlosser
reviewed
Dec 13, 2021
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
jbschlosser
reviewed
Dec 17, 2021
|
@george-qi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33200166](https://our.internmc.facebook.com/intern/diff/D33200166) [ghstack-poisoned]
|
@george-qi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33200166](https://our.internmc.facebook.com/intern/diff/D33200166) [ghstack-poisoned]
Differential Revision: [D33200166](https://our.internmc.facebook.com/intern/diff/D33200166) [ghstack-poisoned]
Differential Revision: [D33200166](https://our.internmc.facebook.com/intern/diff/D33200166) [ghstack-poisoned]
|
@george-qi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
wconstab
pushed a commit
that referenced
this pull request
Jan 5, 2022
Summary: Pull Request resolved: #69054 Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D33200166 Pulled By: george-qi fbshipit-source-id: 9d953744351a25f372418d2a64e8402356d1e9b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D33200166