Write flaky tests to rockset #70136
Closed
Write flaky tests to rockset #70136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 882e912 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
janeyx99
force-pushed
the
write-flaky-tests-to-rockset
branch
from
559a678 to
d49ebb1
Compare
suo
approved these changes
Dec 20, 2021
tools/stats/print_test_stats.py
Outdated
| # write to S3 to go to Rockset as well | ||
| import uuid | ||
| for flaky_test in flaky_tests: | ||
| flaky_test["workflow_job_id"] = workflow_job_id |
There was a problem hiding this comment.
This is ambiguous, there is no concept of a "workflow job" in either GHA or circle. Probably workflow_id is preferred
tools/stats/print_test_stats.py
Outdated
| flaky_test["workflow_job_id"] = workflow_job_id | ||
| key = f'flaky_tests/{workflow_job_id}/{uuid.uuid4()}.json' | ||
| obj = get_S3_object_from_bucket('ossci-raw-job-status', key) | ||
| obj.put(Body=json.dumps(flaky_test).encode()) |
There was a problem hiding this comment.
nit: should set ContentType="application/json" so that if you view the s3 file directly, you browser knows what to do with it.
tools/stats/print_test_stats.py
Outdated
| flaky_test["workflow_job_id"] = workflow_job_id | ||
| key = f'flaky_tests/{workflow_job_id}/{uuid.uuid4()}.json' | ||
| obj = get_S3_object_from_bucket('ossci-raw-job-status', key) | ||
| obj.put(Body=json.dumps(flaky_test).encode()) |
There was a problem hiding this comment.
I don't think you need encode() here, the s3 library will do it for you.
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
suo
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try using Rockset as backend for data instead of RDS