Remove deprecated torch.eig #70982

IvanYashchuk · 2022-01-07T11:29:53Z

The time has come to remove deprecated linear algebra related functions. This PR removes torch.eig.

cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano

pytorch-probot · 2022-01-07T11:29:58Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/IvanYashchuk/pytorch/blob/408912394b4a47960d355a0b012ca2da46893725/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/cuda,ciflow/all

Workflows	Labels (bold enabled)	Status
Triggered Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
docker-builds	`ciflow/all`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	✅ triggered
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2022-01-07T11:29:58Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/70982
✖️ Python docs build was skipped
✖️ C++ docs build was skipped
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit b26952f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

lezcano

Great to see this one gone!

PyTorch's `torch.eig` was deprecated since version 1.9 and is being removed by pytorch/pytorch#70982

malfet

This needs a rebase, but LGTM provided that CI is green

facebook-github-bot · 2022-09-04T20:57:24Z

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kit1980 · 2022-09-04T20:58:43Z

Please do not merge until I confirm the internal tests pass.

IvanYashchuk · 2022-09-07T11:32:06Z

How do internal tests look, did they pass?

kit1980 · 2022-09-07T16:20:21Z

How do internal tests look, did they pass?

Removing one old piece of code that fails currently.

kit1980 · 2022-09-09T02:51:29Z

@IvanYashchuk I'm going to land the diff internally soon, the PR will be merged automatically after that.

Summary: The time has come to remove deprecated linear algebra related functions. This PR removes `torch.eig`. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano X-link: pytorch/pytorch#70982 Reviewed By: malfet Differential Revision: D37966198 Pulled By: kit1980 fbshipit-source-id: 83eccb849480dd022f3c7597755089656187220f

facebook-github-bot · 2022-09-09T21:29:36Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-09-09T21:31:53Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-09T21:32:37Z

Hey @IvanYashchuk.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kit1980 · 2022-09-09T21:34:35Z

Landed!
Hopefully there will be no unforeseen issues...

Summary: The time has come to remove deprecated linear algebra related functions. This PR removes `torch.eig`. cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano Pull Request resolved: #70982 Reviewed By: malfet Differential Revision: D37966198 Pulled By: kit1980 fbshipit-source-id: 83eccb849480dd022f3c7597755089656187220f

kit1980 · 2022-09-09T22:44:53Z

OK, functorch test is failing https://github.com/pytorch/pytorch/runs/8279538230?check_suite_focus=true
I'm trying to forward-fix

After #70982

After #70982 Pull Request resolved: #84787 Approved by: https://github.com/suo, https://github.com/seemethere

… (#84787) Summary: After pytorch/pytorch#70982 X-link: pytorch/pytorch#84787 Approved by: https://github.com/suo, https://github.com/seemethere Reviewed By: izaitsevfb Differential Revision: D39407114 Pulled By: kit1980 fbshipit-source-id: b545cd52dd442930b2a07f7acdf4973d23cc22a1

…#84787) Summary: After #70982 Pull Request resolved: #84787 Approved by: https://github.com/suo, https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f598b5be1825fc0a12b5013c547fb5972b57b208 Reviewed By: izaitsevfb Differential Revision: D39407114 Pulled By: kit1980 fbshipit-source-id: b545cd52dd442930b2a07f7acdf4973d23cc22a1

`eig` is removed from PyTorch by pytorch/pytorch#70982. Update spmd accordingly.

Remove deprecated torch.eig

4d568eb

IvanYashchuk added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: deprecation labels Jan 7, 2022

IvanYashchuk requested review from lezcano and mruberry January 7, 2022 11:29

IvanYashchuk requested review from albanD, ezyang, nikitaved and soulitzer as code owners January 7, 2022 11:29

pytorch-probot bot added the ciflow/cuda label Jan 7, 2022

pytorch-probot bot assigned pytorchbot Jan 7, 2022

facebook-github-bot added the cla signed label Jan 7, 2022

pytorch-probot bot unassigned pytorchbot Jan 7, 2022

IvanYashchuk removed request for ezyang, nikitaved, albanD and soulitzer January 7, 2022 11:30

pytorchbot added the open source label Jan 7, 2022

IvanYashchuk mentioned this pull request Jan 7, 2022

Remove deprecated linear algebra related functions #69857

Closed

3 tasks

IvanYashchuk added the ciflow/all label Jan 7, 2022

dagitses assigned mruberry Jan 10, 2022

dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 10, 2022

Merge remote-tracking branch 'upstream/viable/strict' into remove-eig

4089123

pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Jan 11, 2022

IvanYashchuk mentioned this pull request Jan 13, 2022

Deprecations tracking issue #55953

Open

lezcano approved these changes Jan 19, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/master' into remove-eig

0745c32

kit1980 mentioned this pull request Aug 26, 2022

torch.eig is deprecated for a long time and is being removed locuslab/qpth#50

Closed

fmassa pushed a commit to facebookresearch/xformers that referenced this pull request Aug 29, 2022

Update deprecated torch.eig (#371)

56ef5fd

PyTorch's `torch.eig` was deprecated since version 1.9 and is being removed by pytorch/pytorch#70982

malfet approved these changes Aug 30, 2022

View reviewed changes

IvanYashchuk added 4 commits September 2, 2022 13:50

Merge remote-tracking branch 'upstream/viable/strict' into remove-eig

ec880b2

Remove xfail eig

9cc243e

Merge remote-tracking branch 'upstream/viable/strict' into remove-eig

80b2ade

Merge remote-tracking branch 'upstream/master' into remove-eig

b26952f

pytorchmergebot added the Merged label Sep 9, 2022

pytorchmergebot closed this in 01c54ad Sep 9, 2022

kit1980 added a commit that referenced this pull request Sep 9, 2022

Remove last bit or torch.eig from functorch/test/test_ops.py

5d1280d

After #70982

kit1980 mentioned this pull request Sep 9, 2022

Remove last bit or torch.eig from functorch/test/test_ops.py #84787

Closed

pytorchmergebot pushed a commit that referenced this pull request Sep 9, 2022

Remove last bit or torch.eig from functorch/test/test_ops.py (#84787)

f598b5b

After #70982 Pull Request resolved: #84787 Approved by: https://github.com/suo, https://github.com/seemethere

mrshenli added a commit to mrshenli/tau that referenced this pull request Sep 13, 2022

Remove deprecated eig

41067da

`eig` is removed from PyTorch by pytorch/pytorch#70982. Update spmd accordingly.

mrshenli mentioned this pull request Sep 13, 2022

Remove deprecated eig pytorch/PiPPy#454

Merged

mrshenli added a commit to pytorch/PiPPy that referenced this pull request Sep 13, 2022

Remove deprecated eig (#454)

d2175f3

`eig` is removed from PyTorch by pytorch/pytorch#70982. Update spmd accordingly.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove deprecated torch.eig #70982

Remove deprecated torch.eig #70982

Uh oh!

IvanYashchuk commented Jan 7, 2022 •

edited by pytorch-probot bot

Loading

Uh oh!

pytorch-probot bot commented Jan 7, 2022 •

edited

Loading

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 7, 2022 •

edited

Loading

Uh oh!

lezcano left a comment

Uh oh!

malfet left a comment

Uh oh!

facebook-github-bot commented Sep 4, 2022

Uh oh!

kit1980 commented Sep 4, 2022

Uh oh!

IvanYashchuk commented Sep 7, 2022 •

edited

Loading

Uh oh!

kit1980 commented Sep 7, 2022

Uh oh!

kit1980 commented Sep 9, 2022

Uh oh!

facebook-github-bot commented Sep 9, 2022

Uh oh!

pytorchmergebot commented Sep 9, 2022

Uh oh!

github-actions bot commented Sep 9, 2022

Uh oh!

kit1980 commented Sep 9, 2022

Uh oh!

kit1980 commented Sep 9, 2022

Uh oh!

Uh oh!

Remove deprecated torch.eig #70982

Remove deprecated torch.eig #70982

Uh oh!

Conversation

IvanYashchuk commented Jan 7, 2022 • edited by pytorch-probot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-probot bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

lezcano left a comment

Choose a reason for hiding this comment

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 4, 2022

Uh oh!

kit1980 commented Sep 4, 2022

Uh oh!

IvanYashchuk commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kit1980 commented Sep 7, 2022

Uh oh!

kit1980 commented Sep 9, 2022

Uh oh!

facebook-github-bot commented Sep 9, 2022

Uh oh!

pytorchmergebot commented Sep 9, 2022

Uh oh!

github-actions bot commented Sep 9, 2022

Uh oh!

kit1980 commented Sep 9, 2022

Uh oh!

kit1980 commented Sep 9, 2022

Uh oh!

Uh oh!

IvanYashchuk commented Jan 7, 2022 •

edited by pytorch-probot bot

Loading

pytorch-probot bot commented Jan 7, 2022 •

edited

Loading

facebook-github-bot commented Jan 7, 2022 •

edited

Loading

IvanYashchuk commented Sep 7, 2022 •

edited

Loading