Remove deprecated torch.symeig #70988

IvanYashchuk · 2022-01-07T14:34:06Z

The time has come to remove deprecated linear algebra related functions. This PR removes torch.symeig.

XLA PR: Remove deprecated torch.symeig xla#4498

cc @jianyuh @nikitaved @pearu @mruberry @walterddr @xwang233 @lezcano @mcarilli @ptrblck @leslie-fang-intel @jgong5 @IvanYashchuk

pytorch-probot · 2022-01-07T14:34:11Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/IvanYashchuk/pytorch/blob/badae1c4a817c5e1eb2dec87ce67edc028bd8d49/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/cuda,ciflow/all

Workflows	Labels (bold enabled)	Status
Triggered Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
docker-builds	`ciflow/all`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	✅ triggered
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2022-01-07T14:34:12Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/70988
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 099c50e (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-14T12:26:42.0223462Z AssertionError: Found an invalid operator name: symeig

2022-03-14T12:26:42.0219120Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 318, in <module>
2022-03-14T12:26:42.0219520Z     main()
2022-03-14T12:26:42.0219956Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 201, in main
2022-03-14T12:26:42.0220341Z     run(options.source_yaml, options.output_dir, options.dry_run, options.impl_path)
2022-03-14T12:26:42.0220704Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 292, in run
2022-03-14T12:26:42.0221324Z     parsed_backend_yaml = parse_backend_yaml(source_yaml, grouped_native_functions, backend_indices)
2022-03-14T12:26:42.0221951Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 100, in parse_backend_yaml
2022-03-14T12:26:42.0222512Z     supported, backend_key, use_out_as_primary=use_out_as_primary, use_device_guard=use_device_guard)
2022-03-14T12:26:42.0222858Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 81, in create_backend_index
2022-03-14T12:26:42.0223172Z     assert op_name in native_functions_map, f"Found an invalid operator name: {op_name}"
2022-03-14T12:26:42.0223462Z AssertionError: Found an invalid operator name: symeig
2022-03-14T12:26:42.0730630Z Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']
2022-03-14T12:26:42.1975012Z + cleanup
2022-03-14T12:26:42.1975297Z + retcode=1
2022-03-14T12:26:42.1975566Z + set +x
2022-03-14T12:26:42.2015370Z ##[error]Process completed with exit code 1.
2022-03-14T12:26:42.2047788Z ##[group]Run # Ensure the working directory gets chowned back to the current user
2022-03-14T12:26:42.2048134Z �[36;1m# Ensure the working directory gets chowned back to the current user�[0m
2022-03-14T12:26:42.2048432Z �[36;1mdocker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .�[0m
2022-03-14T12:26:42.2059892Z shell: /usr/bin/bash -e {0}
2022-03-14T12:26:42.2060061Z env:

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

lezcano

Just a couple points

aten/src/ATen/native/cuda/BatchLinearAlgebra.cpp

tools/autograd/derivatives.yaml

This reverts commit d70ed68. Reverted #70988 on behalf of https://github.com/kit1980 due to Failing XLA tests, forward fix unsuccessful

This reverts commit 2740daf. Reverted #90887 on behalf of https://github.com/huydhn due to Sorry for reverting your PR. We reverted #70988 in https://hud.pytorch.org/pytorch/pytorch/commit/acdd462b1a070790799ce4623ce8ecc83e197e81 and this test starts to fail. There is probably a dependency between the twos

This test inspects the dispatcher directly, so captures operators without `OpInfo` including internal helper operators and backward operators that might appear in a trace. Pull Request resolved: #90887 Approved by: https://github.com/ezyang

IvanYashchuk · 2023-01-30T17:51:17Z

@pytorchbot merge -g

pytorchmergebot · 2023-01-30T17:53:01Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-01-30T17:53:05Z

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team

Raised by workflow job

IvanYashchuk · 2023-01-30T22:56:31Z

XLA is passing: https://github.com/pytorch/pytorch/actions/runs/4046657961/jobs/6960036431

IvanYashchuk · 2023-01-31T11:56:12Z

Some CI jobs are failing (e.g. https://github.com/pytorch/pytorch/actions/runs/4048928070/jobs/6974815885):

Error response from daemon: manifest for 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-py3.8-gcc7:82d9d2b1e97524ec4988a070c31f4a2655ef32a3 not found: manifest unknown: Requested image not found
Error response from daemon: manifest for 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-py3.8-gcc7:82d9d2b1e97524ec4988a070c31f4a2655ef32a3 not found: manifest unknown: Requested image not found
Error response from daemon: manifest for 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-py3.8-gcc7:82d9d2b1e97524ec4988a070c31f4a2655ef32a3 not found: manifest unknown: Requested image not found
Error: Process completed with exit code 1.

IvanYashchuk · 2023-01-31T11:57:25Z

@pytorchbot merge -f "XLA is passing, PR was green except for the XLA job"

pytorchmergebot · 2023-01-31T11:59:03Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

torch.symeig was removed pytorch/pytorch#70988

* Update removed torch.symeig from parametrizations.py torch.symeig was removed pytorch/pytorch#70988 --------- Co-authored-by: Mario Lezcano Casado <3291265+lezcano@users.noreply.github.com>

Remove deprecated torch.symeig

f284a7a

IvanYashchuk added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: deprecation labels Jan 7, 2022

IvanYashchuk requested a review from mruberry January 7, 2022 14:34

IvanYashchuk requested review from albanD, ezyang, lezcano, nikitaved and soulitzer as code owners January 7, 2022 14:34

pytorch-probot bot added the ciflow/cuda label Jan 7, 2022

pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Jan 7, 2022

facebook-github-bot added the cla signed label Jan 7, 2022

IvanYashchuk removed request for ezyang, nikitaved, albanD and soulitzer January 7, 2022 14:34

IvanYashchuk mentioned this pull request Jan 7, 2022

Remove deprecated linear algebra related functions #69857

Closed

3 tasks

IvanYashchuk added the ciflow/all label Jan 7, 2022

pytorchbot added the open source label Jan 7, 2022

dagitses assigned mruberry Jan 10, 2022

dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 10, 2022

Merge remote-tracking branch 'upstream/viable/strict' into remove-symeig

badae1c

pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Jan 11, 2022

IvanYashchuk mentioned this pull request Jan 13, 2022

Deprecations tracking issue #55953

Open

lezcano reviewed Jan 19, 2022

View reviewed changes

aten/src/ATen/native/cuda/BatchLinearAlgebra.cpp Outdated Show resolved Hide resolved

tools/autograd/derivatives.yaml Outdated Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into remove-symeig

8bba80d

pytorchmergebot added the Reverted label Jan 24, 2023

pytorchmergebot added a commit that referenced this pull request Jan 24, 2023

Revert "Remove deprecated torch.symeig (#70988)"

acdd462

This reverts commit d70ed68. Reverted #70988 on behalf of https://github.com/kit1980 due to Failing XLA tests, forward fix unsuccessful

IvanYashchuk reopened this Jan 24, 2023

IvanYashchuk added 2 commits January 24, 2023 21:30

Merge remote-tracking branch 'upstream/master' into remove-symeig

eeba18c

Update xla pin

48be719

IvanYashchuk requested a review from a team as a code owner January 24, 2023 19:31

IvanYashchuk added the ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow label Jan 24, 2023

huydhn mentioned this pull request Jan 24, 2023

Add test tracking operators without decompositions #90887

Closed

IvanYashchuk added 4 commits January 25, 2023 19:36

Update pin

2cb4876

Update pin; xla PR got merged

7f9d4b5

Merge remote-tracking branch 'upstream/viable/strict' into remove-symeig

06b7c0b

Restore xla pin

2cd4cc6

malfet approved these changes Jan 30, 2023

View reviewed changes

Pin xla past pytorch/xla@903f2ac

bdeb51e

IvanYashchuk removed the ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow label Jan 30, 2023

Remove symeig from HasDecompTest.test_has_decomposition.expect

5a758f9

pytorchmergebot closed this in fba13d9 Jan 31, 2023

kit1980 added a commit to pytorch/tutorials that referenced this pull request Jun 15, 2023

Update removed torch.symeig from parametrizations.py

29466db

torch.symeig was removed pytorch/pytorch#70988

kit1980 mentioned this pull request Jun 15, 2023

Update removed torch.symeig in parametrizations.py pytorch/tutorials#2472

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove deprecated torch.symeig #70988

Remove deprecated torch.symeig #70988

Uh oh!

IvanYashchuk commented Jan 7, 2022 •

edited

Loading

Uh oh!

pytorch-probot bot commented Jan 7, 2022 •

edited

Loading

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 7, 2022 •

edited

Loading

Uh oh!

lezcano left a comment

Uh oh!

Uh oh!

Uh oh!

IvanYashchuk commented Jan 30, 2023

Uh oh!

pytorchmergebot commented Jan 30, 2023

Uh oh!

pytorchmergebot commented Jan 30, 2023

Uh oh!

IvanYashchuk commented Jan 30, 2023

Uh oh!

IvanYashchuk commented Jan 31, 2023

Uh oh!

IvanYashchuk commented Jan 31, 2023

Uh oh!

pytorchmergebot commented Jan 31, 2023

Uh oh!

Uh oh!

Remove deprecated torch.symeig #70988

Remove deprecated torch.symeig #70988

Uh oh!

Conversation

IvanYashchuk commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-probot bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Uh oh!

lezcano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

IvanYashchuk commented Jan 30, 2023

Uh oh!

pytorchmergebot commented Jan 30, 2023

Merge started

Uh oh!

pytorchmergebot commented Jan 30, 2023

Merge failed

Uh oh!

IvanYashchuk commented Jan 30, 2023

Uh oh!

IvanYashchuk commented Jan 31, 2023

Uh oh!

IvanYashchuk commented Jan 31, 2023

Uh oh!

pytorchmergebot commented Jan 31, 2023

Merge started

Uh oh!

Uh oh!

IvanYashchuk commented Jan 7, 2022 •

edited

Loading

pytorch-probot bot commented Jan 7, 2022 •

edited

Loading

facebook-github-bot commented Jan 7, 2022 •

edited

Loading