[FSDP] Generalize fsdp_modules() #73553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/) [ghstack-poisoned]
fegin
requested review from
mrshenli,
zhaojuanmao,
pritamdamania87,
rohan-varma,
mingzhe09088 and
H-Huang
as code owners
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 39a6c15 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
CI Flow Status⚛️ CI FlowRuleset - Version:
|
This was referenced Mar 1, 2022
facebook-github-bot
added
the
oncall: distributed
fegin
added a commit
that referenced
this pull request
Mar 1, 2022
Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/) ghstack-source-id: 150164370 Pull Request resolved: #73553
rohan-varma
reviewed
Mar 1, 2022
zhaojuanmao
reviewed
Mar 1, 2022
Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/) [ghstack-poisoned]
Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Mar 3, 2022
Pull Request resolved: #73553 Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). ghstack-source-id: 150392207 Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/)
Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Mar 3, 2022
Pull Request resolved: #73553 Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). ghstack-source-id: 150442403 Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/)
Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Mar 7, 2022
Pull Request resolved: #73553 Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). ghstack-source-id: 150690955 Differential Revision: [D34537408](https://our.internmc.facebook.com/intern/diff/D34537408/)
rohan-varma
approved these changes
Mar 8, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Summary: Pull Request resolved: #73553 Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). ghstack-source-id: 150690955 Test Plan: CI Reviewed By: rohan-varma Differential Revision: D34537408 fbshipit-source-id: 1bf057704954e8177d0a28f2b3d0dae4da882249
|
Hey @fegin. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#73553 Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). ghstack-source-id: 150690955 Test Plan: CI Reviewed By: rohan-varma Differential Revision: D34537408 fbshipit-source-id: 1bf057704954e8177d0a28f2b3d0dae4da882249 (cherry picked from commit 437aad7a3b612ca275213c32c2fa6ac37f2ed3ab)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#73553 Generalize fsdp_modules(): 1. Make fsdp_modules() a static method so that it can be called even when users have no reference to the FSDP module -- it can be wrapped inside an non-FSDP module. 2. Add root_only option to returns only the root FSDP module(s). ghstack-source-id: 150690955 Test Plan: CI Reviewed By: rohan-varma Differential Revision: D34537408 fbshipit-source-id: 1bf057704954e8177d0a28f2b3d0dae4da882249 (cherry picked from commit 437aad7a3b612ca275213c32c2fa6ac37f2ed3ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Generalize fsdp_modules():
Differential Revision: D34537408