[ONNX] Adjust is_train flag for onnx pass deduplicate initializers
#74247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenBao
added
release notes: onnx
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5c7afc8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zou3519
added
the
triaged
Previous logic didn't consider the case for TrainingMode.PRESERVE. A more direct way is to check `model.training`, which is the accurate training mode, set by `exporter_context(model, training)`.
|
I will fix the CI issue before merging |
BowenBao
force-pushed
the
onnx_dedup_training
branch
from
bec9fa7 to
00797e1
Compare
garymm
reviewed
Mar 21, 2022
|
@pytorchbot merge this |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
…74247) Summary: Previous logic didn't consider the case for TrainingMode.PRESERVE. A more direct way is to check `model.training`, which is the accurate training mode, set by `exporter_context(model, training)`. Pull Request resolved: #74247 Approved by: https://github.com/garymm Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/144b7de9dd5f5fea03330d5447c888be6ecd08cf Reviewed By: malfet Differential Revision: D35065521 fbshipit-source-id: 05eb5797763a30e647711f8af6a415122c404a98
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Previous logic didn't consider the case for TrainingMode.PRESERVE. A more direct way is to check `model.training`, which is the accurate training mode, set by `exporter_context(model, training)`. Pull Request resolved: #74247 Approved by: https://github.com/garymm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous logic didn't consider the case for TrainingMode.PRESERVE.
A more direct way is to check
model.training, which is the accuratetraining mode, set by
exporter_context(model, training).