Skip to content

[PT-D][Sharding] Fix view op and matrix ops unit test #77706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[PT-D][Sharding] Fix view op and matrix ops unit test #77706

wants to merge 1 commit into from

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented May 18, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

To fix a corner case when the sharding dim is negative number we need to handle it correctly. Add unit test to cover this corner case, too.

Also disable RPC for matrix ops which are not necessary and they fail on AWS pytest.

Differential Revision: D36464797

@fduwjj
[PT-D][Sharding] Fix view op and matrix ops unit test
9d815d1 
To fix a corner case when the sharding dim is negative number we need to handle it correctly.

Also disable RPC for matrix ops which are not necessary and they fail on AWS pytest.

Differential Revision: [D36464797](https://our.internmc.facebook.com/intern/diff/D36464797/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 18, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 9d815d1 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue labels May 18, 2022
fduwjj added a commit that referenced this pull request May 18, 2022
@fduwjj
[PT-D][Sharding] Fix view op and matrix ops unit test
c3bdbe1 
To fix a corner case when the sharding dim is negative number we need to handle it correctly.

Also disable RPC for matrix ops which are not necessary and they fail on AWS pytest.

Differential Revision: [D36464797](https://our.internmc.facebook.com/intern/diff/D36464797/)

ghstack-source-id: 156617305
Pull Request resolved: #77706
@fduwjj fduwjj requested a review from wanchaol May 18, 2022 00:10
@fduwjj
Copy link
Contributor Author

fduwjj commented May 18, 2022

@pytorchbot merge this please

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) linux-docs / build-docs (cpp) are not yet run for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2342289564

wanchaol
wanchaol approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fduwjj
Copy link
Contributor Author

fduwjj commented May 18, 2022

@pytorchmergebot merge this please

@github-actions
Copy link
Contributor

Hey @fduwjj.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@fduwjj fduwjj added the topic: bug fixes topic category label May 18, 2022
facebook-github-bot pushed a commit that referenced this pull request May 20, 2022
@fduwjj @facebook-github-bot
[PT-D][Sharding] Fix view op and matrix ops unit test (#77706)
2f5906a 
Summary:
To fix a corner case when the sharding dim is negative number we need to handle it correctly.

Also disable RPC for matrix ops which are not necessary and they fail on AWS pytest.

Pull Request resolved: #77706

Approved by: https://github.com/pritamdamania87, https://github.com/wanchaol

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/3b2375291aab7b48442f2e6fb1ef66cebc761e24

Reviewed By: pritamdamania87, seemethere, wanchaol

Differential Revision: D36464797

Pulled By: fduwjj

fbshipit-source-id: d1933c296f2245532121cce9efc1c5c56108e025
@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/30/head branch May 21, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanchaol wanchaol wanchaol approved these changes

@pritamdamania87 pritamdamania87 pritamdamania87 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

Assignees
No one assigned
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (sharded) release notes category sharded_tensor topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fduwjj @facebook-github-bot @pytorchmergebot @wanchaol @pritamdamania87