Add complex_to_float option in ReductionOpInfo #78423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per title [ghstack-poisoned]
🔗 Helpful links
❌ 1 New FailuresAs of commit 7ab07c0 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced May 27, 2022
lezcano
added
module: testing
As per title [ghstack-poisoned]
|
What's up with test failures? They don't seem related, but also trunk doesn't look broken. |
ngimel
reviewed
May 27, 2022
| kwargs=kwargs)) | ||
|
|
||
| return inputs | ||
| yield SampleInput(t.detach().requires_grad_(requires_grad), args=args, kwargs=kwargs) |
There was a problem hiding this comment.
wow previous invocation seems buggy, bringing unneeded history.
There was a problem hiding this comment.
I do not understand how the previous implementation worked tbh... I should look further into that.
This little fix needed some extra fixes here and there (hence the test failures). I needed to convert quite a few other functions into generators after this one. Let's see if I managed to not miss any one.
| @@ -1381,6 +1378,7 @@ def __init__( | |||
| # These are mutually exclusive options | |||
| assert not (result_dtype and promotes_int_to_float) | |||
| assert not (result_dtype and promotes_int_to_int64) | |||
| assert not (result_dtype and complex_to_real) | |||
There was a problem hiding this comment.
but vector_norm accepts dtype arg?
There was a problem hiding this comment.
result_dtype is used to specify when a function always returns a given dtype (e.g. eq).
As per title [ghstack-poisoned]
As per title [ghstack-poisoned]
ngimel
approved these changes
May 31, 2022
This was referenced Jun 1, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
Summary: As per title Pull Request resolved: #78423 Approved by: https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9b97d5d625b02ed27a22d9e3c981caa4b1dea5c7 Reviewed By: seemethere Differential Revision: D36815705 Pulled By: seemethere fbshipit-source-id: d9e59c329bc63e56719ae39c07c71d8d656b198b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As per title