Skip to content

fix gather sparse_grad backward crash with empty index tensor #78698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix gather sparse_grad backward crash with empty index tensor #78698

wants to merge 2 commits into from

Conversation

yuguo68
Copy link
Contributor

@yuguo68 yuguo68 commented Jun 2, 2022 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit e879502 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

yuguo68 added a commit that referenced this pull request Jun 2, 2022
@yuguo68
fix gather sparse_grad backward crash with empty index tensor
1b9a173 
ghstack-source-id: 1bc3158
Pull Request resolved: #78698
@yuguo68 yuguo68 requested a review from ngimel June 2, 2022 03:07
ngimel
ngimel approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

yuguo68 added a commit that referenced this pull request Jun 3, 2022
@yuguo68
fix gather sparse_grad backward crash with empty index tensor
9ed76f3 
ghstack-source-id: 634cc90
Pull Request resolved: #78698
@yuguo68
Copy link
Contributor Author

yuguo68 commented Jun 4, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

Hey @yuguo68.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 6, 2022
@yuguo68 @facebook-github-bot
fix gather sparse_grad backward crash with empty index tensor (#78698)
ff65f51 
Summary:
Pull Request resolved: #78698

Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/519347df49fe50fb46f40544e22225be485efb06

Reviewed By: seemethere

Differential Revision: D36935447

Pulled By: yuguo68

fbshipit-source-id: 42be3bd5f9b5a36e6abd091b9272ff3142c6ce71
@facebook-github-bot facebook-github-bot deleted the gh/yuguo68/7/head branch June 7, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuguo68 @facebook-github-bot @pytorchmergebot @ngimel