Skip to content

Conversation

manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Jun 3, 2022

Differential Revision: [D36674287](https://our.internmc.facebook.com/intern/diff/D36674287/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36674287/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 3, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 756f3b2 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 3, 2022
manuelcandales added a commit that referenced this pull request Jun 3, 2022
Differential Revision: [D36674287](https://our.internmc.facebook.com/intern/diff/D36674287/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36674287/)!

ghstack-source-id: 157782979
Pull Request resolved: #78818
Differential Revision: [D36674287](https://our.internmc.facebook.com/intern/diff/D36674287/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36674287/)!

[ghstack-poisoned]
manuelcandales added a commit that referenced this pull request Jun 3, 2022
Pull Request resolved: #78818


ghstack-source-id: 158036184

Differential Revision: [D36674287](https://our.internmc.facebook.com/intern/diff/D36674287/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36674287/)!
Differential Revision: [D36674287](https://our.internmc.facebook.com/intern/diff/D36674287/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36674287/)!

[ghstack-poisoned]
manuelcandales added a commit that referenced this pull request Jun 6, 2022
Pull Request resolved: #78818


ghstack-source-id: 158143558

Differential Revision: [D36674287](https://our.internmc.facebook.com/intern/diff/D36674287/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36674287/)!
@manuelcandales manuelcandales requested review from SS-JIA and removed request for SS-JIA June 6, 2022 17:47
@SS-JIA SS-JIA self-requested a review June 6, 2022 17:58
@manuelcandales manuelcandales merged commit 44a2b8d into gh/manuelcandales/5/base Jun 8, 2022
facebook-github-bot pushed a commit that referenced this pull request Jun 8, 2022
Summary:
Pull Request resolved: #78818

ghstack-source-id: 158143558

Reviewed By: SS-JIA

Differential Revision: D36674287

fbshipit-source-id: e6b5886468ea405d150aeaf117e4072a52e1bab2
bigfootjon pushed a commit that referenced this pull request Jun 8, 2022
Summary:
Pull Request resolved: #78818

ghstack-source-id: 158143558

Reviewed By: SS-JIA

Differential Revision: D36674287

fbshipit-source-id: e6b5886468ea405d150aeaf117e4072a52e1bab2
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Hey @manuelcandales.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/manuelcandales/5/head branch July 8, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants