Skip to content

Add Tensor.is_cpu #78887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add Tensor.is_cpu #78887

wants to merge 7 commits into from

Conversation

vitrioil
Copy link
Contributor

@vitrioil vitrioil commented Jun 5, 2022 •
edited
Loading

Fixes #76872

Not sure if this is also required.

pytorch/torch/csrc/tensor/python_tensor.cpp

Line 146 in ac8c6d0

{"is_cuda", (getter)Tensor_is_cuda, nullptr, nullptr, nullptr},

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 5, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 8025929 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@vitrioil vitrioil changed the title Add Torch.is_cpu Add Tensor.is_cpu Jun 5, 2022
@vitrioil vitrioil marked this pull request as ready for review June 5, 2022 10:48
@vitrioil vitrioil requested review from albanD and soulitzer as code owners June 5, 2022 10:48
@ezyang
Copy link
Contributor

ezyang commented Jun 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Hey @vitrioil.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2022
@vitrioil @facebook-github-bot
Add Tensor.is_cpu (#78887) (#78887)
5430f91 
Summary:
Fixes #76872

Not sure if this is also required.
https://github.com/pytorch/pytorch/blob/ac8c6d09d1ce0a239f97473ebc01f1fe0ec87dcd/torch/csrc/tensor/python_tensor.cpp#L146

Pull Request resolved: #78887
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ebb7f424b82d5b19d995e98ba7166a197c75fb59

Reviewed By: osalpekar

Differential Revision: D36959262

Pulled By: osalpekar

fbshipit-source-id: 48b92bdfa6b11df84d78aab62db9ccb1d3efab40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees
No one assigned
Labels
cla signed Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tensor.is_cpu
5 participants
@vitrioil @facebook-github-bot @ezyang @pytorchmergebot @pytorchbot