Skip to content

DOC: Harmonize ELU documentation with the module doc #78909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DOC: Harmonize ELU documentation with the module doc #78909

wants to merge 1 commit into from

Conversation

HaoZeke
Copy link
Collaborator

@HaoZeke HaoZeke commented Jun 6, 2022

Fixes #77055 by simply referring to the module docs as noted in the issue.

@HaoZeke HaoZeke requested a review from mruberry June 6, 2022 01:14
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 6, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit e3fe3af (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@HaoZeke HaoZeke changed the title DOC: Harmonize with the module doc DOC: Harmonize ELU documentation with the module doc Jun 6, 2022
@mruberry
Copy link
Collaborator

mruberry commented Jun 6, 2022

We should also fix the module doc to use expm1 properly

albanD
albanD approved these changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@albanD
Copy link
Collaborator

albanD commented Jun 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Hey @HaoZeke.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@albanD
Copy link
Collaborator

albanD commented Jun 6, 2022

@HaoZeke Mike's suggestion about the use of exp1m would be a good thing to add in a follow up though!

facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2022
@HaoZeke @facebook-github-bot
DOC: Harmonize ELU documentation with the module doc (#78909) (#78909)
8a711ed 
Summary:
Fixes #77055 by simply referring to the module docs as noted in the issue.

Pull Request resolved: #78909
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/5a95b20d0f38e74fd3cedf87d236b6b4649e5f74

Reviewed By: seemethere

Differential Revision: D36935602

Pulled By: seemethere

fbshipit-source-id: a72d6185de01ada91872a52cf845a81b4ebb420d
@HaoZeke
Copy link
Collaborator Author

HaoZeke commented Jun 23, 2022

We should also fix the module doc to use expm1 properly

@HaoZeke Mike's suggestion about the use of exp1m would be a good thing to add in a follow up though!

Would be happy to, only I'm not entirely sure what / where the problem with the module doc is (also if its for ELU or expm1..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees
No one assigned
Labels
cla signed Merged module: primTorch open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix Elu docs
6 participants
@HaoZeke @facebook-github-bot @mruberry @albanD @pytorchmergebot @pytorchbot