add kineto and flatbuffers to OSS BUCK #79860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

linbinyu wants to merge 1 commit into pytorch:master from linbinyu:export-D37273088

Contributor

linbinyu commented Jun 20, 2022

Summary: add two third-party libraries kineto and flatbuffers to OSS BUCK build

Test Plan:
local test.
CI

Differential Revision: D37273088

facebook-github-bot added the cla signed label

Contributor

facebook-github-bot commented Jun 20, 2022 •

edited

Loading

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/79860
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit f42fad5 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jun 20, 2022

This pull request was exported from Phabricator. Differential Revision: D37273088

linbinyu added the ciflow/periodic label

linbinyu requested a review from kit1980

June 20, 2022 07:29

linbinyu added the ciflow/trunk label

Contributor

facebook-github-bot commented Jun 20, 2022

This pull request was exported from Phabricator. Differential Revision: D37273088

linbinyu force-pushed the export-D37273088 branch from 7a31d69 to ea51701 Compare

June 20, 2022 16:47

Contributor

facebook-github-bot commented Jun 20, 2022

This pull request was exported from Phabricator. Differential Revision: D37273088

linbinyu force-pushed the export-D37273088 branch from ea51701 to a623c1a Compare

June 20, 2022 17:00

linbinyu removed the ciflow/periodic label

Contributor

facebook-github-bot commented Jun 20, 2022

This pull request was exported from Phabricator. Differential Revision: D37273088

linbinyu force-pushed the export-D37273088 branch from a623c1a to e9a603a Compare

June 20, 2022 18:00

linbinyu force-pushed the export-D37273088 branch from e9a603a to eace299 Compare

June 20, 2022 18:56

Contributor

facebook-github-bot commented Jun 20, 2022

This pull request was exported from Phabricator. Differential Revision: D37273088

linbinyu added a commit to linbinyu/pytorch that referenced this pull request


          add kineto and flatbuffers to OSS BUCK (pytorch#79860)

d6df352

Summary:
Pull Request resolved: pytorch#79860

add two third-party libraries kineto and flatbuffers to OSS BUCK build

Test Plan:
local test.
CI

Differential Revision: D37273088

fbshipit-source-id: 3bfa663a1aa5f46f79df109f72be282d8cb7eb6a

linbinyu force-pushed the export-D37273088 branch from eace299 to d6df352 Compare

June 20, 2022 20:13

Contributor

facebook-github-bot commented Jun 20, 2022

This pull request was exported from Phabricator. Differential Revision: D37273088

kit1980 approved these changes

View reviewed changes


          add kineto and flatbuffers to OSS BUCK (pytorch#79860)

f42fad5

Summary:
Pull Request resolved: pytorch#79860

add two third-party libraries kineto and flatbuffers to OSS BUCK build

Test Plan:
local test.
CI

Reviewed By: kit1980

Differential Revision: D37273088

fbshipit-source-id: 9dc715df4f0f1401505a0c8b9e8d9ad3a1e84e45

Contributor

facebook-github-bot commented Jun 21, 2022

This pull request was exported from Phabricator. Differential Revision: D37273088

linbinyu force-pushed the export-D37273088 branch from d6df352 to f42fad5 Compare

June 21, 2022 01:07

Contributor

facebook-github-bot commented Jun 21, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

Collaborator

pytorchmergebot commented Jun 21, 2022

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

d8b6806

Contributor

github-actions bot commented Jun 21, 2022

Hey @linbinyu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request


          add kineto and flatbuffers to OSS BUCK (#79860)

Summary:
Pull Request resolved: #79860

add two third-party libraries kineto and flatbuffers to OSS BUCK build

Test Plan:
local test.
CI

Reviewed By: kit1980

Differential Revision: D37273088

fbshipit-source-id: d8b4588131e16218f5aad0963fdffa8c43340825

miladm pushed a commit to miladm/pytorch that referenced this pull request


          add kineto and flatbuffers to OSS BUCK (pytorch#79860)

4c669c7

Summary: add two third-party libraries kineto and flatbuffers to OSS BUCK build

Test Plan:
local test.
CI

Differential Revision: D37273088

Pull Request resolved: pytorch#79860
Approved by: https://github.com/kit1980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk cla signed fb-exported Merged