Skip to content

Update release.md with rc validation steps #79889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Update release.md with rc validation steps #79889

wants to merge 5 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jun 20, 2022

Update release.md with rc validation steps

@atalman
Update release.md with rc validation steps
387d689 
Update release.md with rc validation steps
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 20, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 403232a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

atalman
atalman commented Jun 20, 2022
View reviewed changes
malfet
malfet reviewed Jun 20, 2022
View reviewed changes
atalman and others added 3 commits June 20, 2022 15:17
@atalman @malfet
Update RELEASE.md
75cbfc2 
Co-authored-by: Nikita Shulga <nshulga@fb.com>
@atalman @malfet
Update RELEASE.md
07a014d 
Co-authored-by: Nikita Shulga <nshulga@fb.com>
@atalman
Addressing feedback
403232a
@atalman
Copy link
Contributor Author

atalman commented Jun 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

@atalman your PR has been successfully merged.

@github-actions
Copy link
Contributor

Hey @atalman.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@atalman @facebook-github-bot
Update release.md with rc validation steps (#79889) (#79889)
9ca2877 
Summary:
Update release.md with rc validation steps

Pull Request resolved: #79889
Approved by: https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/344c55cdd976c5354e1c5b1ed544265e90313e28

Reviewed By: albanD

Differential Revision: D37327423

Pulled By: atalman

fbshipit-source-id: d0d34745838c6b1b923bfed74a7879cec428039e
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@atalman @miladm
Update release.md with rc validation steps (pytorch#79889)
0172d16 
Update release.md with rc validation steps

Pull Request resolved: pytorch#79889
Approved by: https://github.com/seemethere
@github-actions github-actions bot deleted the atalman-patch-6 branch February 17, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet left review comments

@seemethere seemethere seemethere approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atalman @facebook-github-bot @pytorchmergebot @seemethere @malfet