Skip to content

stream pkl #79931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

stream pkl #79931

wants to merge 1 commit into from

Conversation

qihqi
Copy link
Contributor

@qihqi qihqi commented Jun 21, 2022

Summary: Let the stream version of pickle loader to short circuit early

Test Plan:
this might affects loading peak mem
before:

Differential Revision: D37304855

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 5d26704 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Jun 21, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37304855

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37304855

@qihqi qihqi force-pushed the export-D37304855 branch from 25df190 to 1d5a7b8 Compare June 21, 2022 06:25
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37304855

@qihqi qihqi force-pushed the export-D37304855 branch from 1d5a7b8 to b0ef4c3 Compare June 21, 2022 14:21
@qihqi @facebook-github-bot
make stream version of pkl load_for_mobile shortcircuit (pytorch#79931)
5d26704 
Summary:
Pull Request resolved: pytorch#79931

Let the stream version of pickle loader to short circuit early

Test Plan:
this might affects loading peak mem
before:
{F745391609}
after:
{F745391713}

Differential Revision: D37304855

fbshipit-source-id: d92fb32435808945dd64520225c2cab3b6607848
@qihqi qihqi force-pushed the export-D37304855 branch from b0ef4c3 to 5d26704 Compare June 21, 2022 18:04
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37304855

junesg
junesg approved these changes Jun 22, 2022
View reviewed changes
Copy link

@junesg junesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark showed on-device peak memory improvement.

davidberard98
davidberard98 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh1 stamp

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

1 similar comment
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

@qihqi your PR has been successfully merged.

@github-actions
Copy link
Contributor

Hey @qihqi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@qihqi @facebook-github-bot
make stream version of pkl load_for_mobile shortcircuit (#79931)
7f848b4 
Summary:
Pull Request resolved: #79931

Let the stream version of pickle loader to short circuit early

Test Plan:
this might affects loading peak mem
before:
{F745391609}
after:
{F745391713}

Reviewed By: junesg, davidberard98

Differential Revision: D37304855

fbshipit-source-id: b5813cd73ec2b508f30e1f3dd37212a98e49cfae
@kimishpatel kimishpatel added the release notes: mobile release notes category label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberard98 davidberard98 davidberard98 approved these changes

+1 more reviewer

@junesg junesg junesg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: mobile release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qihqi @facebook-github-bot @pytorchmergebot @junesg @davidberard98 @kimishpatel