Skip to content

[3] move aten targets to shared buck file #79966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3] move aten targets to shared buck file #79966

wants to merge 1 commit into from

Conversation

linbinyu
Copy link
Contributor

Summary: move aten related targets to the shared buck file

Test Plan: Github CI, sandcastle

Differential Revision: D37323401

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit 71ad303 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build periodic / ios-12-5-1-arm64-coreml / build (1/1)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2022-06-23T06:28:34.5759030Z ##[error]The operation was canceled. 
2022-06-23T03:39:26.7706540Z 
2022-06-23T03:39:26.7707860Z CodeSign /Users/runner/work/pytorch/pytorch/ios/TestApp/build/Release-iphoneos/TestApp.app (in target 'TestApp' from project 'TestApp')
2022-06-23T03:39:26.7708400Z     cd /Users/runner/work/pytorch/pytorch/ios/TestApp
2022-06-23T03:39:26.7708850Z     export CODESIGN_ALLOCATE\=/Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate
2022-06-23T03:39:26.7709210Z     
2022-06-23T03:39:26.7709470Z Signing Identity:     "Apple Development: Tao Xu (Q7PV3L5FKY)"
2022-06-23T03:39:26.7709770Z Provisioning Profile: "PyTorch_CI_2022"
2022-06-23T03:39:26.7711170Z                       (4aacbe80-cff0-4415-9ae8-c84476678cd5)
2022-06-23T03:39:26.7711350Z 
2022-06-23T03:39:26.7712460Z     /usr/bin/codesign --force --sign 31F7F74EFAF97190E9C2F6C230C27D3AC1861A63 --entitlements /Users/runner/work/pytorch/pytorch/ios/TestApp/build/TestApp.build/Release-iphoneos/TestApp.build/TestApp.app.xcent --timestamp\=none /Users/runner/work/pytorch/pytorch/ios/TestApp/build/Release-iphoneos/TestApp.app
2022-06-23T06:28:34.5759030Z ##[error]The operation was canceled.
2022-06-23T06:28:34.5875550Z Post job cleanup.
2022-06-23T06:28:34.5936220Z Post job cleanup.
2022-06-23T06:28:35.1569990Z [command]/usr/local/bin/git version
2022-06-23T06:28:35.1575960Z git version 2.36.1
2022-06-23T06:28:35.1582270Z Copying '/Users/runner/.gitconfig' to '/Users/runner/work/_temp/7741428b-27a7-4f03-840c-0e06e5107c61/.gitconfig'
2022-06-23T06:28:35.1583230Z Temporarily overriding HOME='/Users/runner/work/_temp/7741428b-27a7-4f03-840c-0e06e5107c61' before making global git config changes
2022-06-23T06:28:35.1583990Z Adding repository directory to the temporary git global config as a safe directory
2022-06-23T06:28:35.1584830Z [command]/usr/local/bin/git config --global --add safe.directory /Users/runner/work/pytorch/pytorch
2022-06-23T06:28:35.1585690Z [command]/usr/local/bin/git config --local --name-only --get-regexp core\.sshCommand
2022-06-23T06:28:35.1586730Z [command]/usr/local/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

@linbinyu linbinyu requested review from iseeyuan, kit1980 and malfet June 21, 2022 20:27
@linbinyu linbinyu added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 21, 2022
iseeyuan
iseeyuan approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure the internal CI passes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

linbinyu added a commit to linbinyu/pytorch that referenced this pull request Jun 22, 2022
@linbinyu @facebook-github-bot
[3] move aten targets to shared buck file (pytorch#79966)
7320a5b 
Summary:
Pull Request resolved: pytorch#79966

move aten related targets to the shared buck file

Test Plan: Github CI, sandcastle

Reviewed By: iseeyuan

Differential Revision: D37323401

fbshipit-source-id: e1c2ec2fcd73fc33d2dc43f3b9d167741022d8b0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

linbinyu added a commit to linbinyu/pytorch that referenced this pull request Jun 22, 2022
@linbinyu @facebook-github-bot
[3] move aten targets to shared buck file (pytorch#79966)
b6cb7df 
Summary:
Pull Request resolved: pytorch#79966

move aten related targets to the shared buck file

Test Plan: Github CI, sandcastle

Reviewed By: iseeyuan

Differential Revision: D37323401

fbshipit-source-id: f4a7042db3f86a52fbf819f9795e65f4a3db7918
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

linbinyu added a commit to linbinyu/pytorch that referenced this pull request Jun 22, 2022
@linbinyu @facebook-github-bot
[3] move aten targets to shared buck file (pytorch#79966)
15184a4 
Summary:
Pull Request resolved: pytorch#79966

move aten related targets to the shared buck file

Test Plan: Github CI, sandcastle

Reviewed By: iseeyuan

Differential Revision: D37323401

fbshipit-source-id: 71457aa36c43c7a65f83a4bcdebfbe990612eb8a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

linbinyu added a commit to linbinyu/pytorch that referenced this pull request Jun 22, 2022
@linbinyu @facebook-github-bot
[3] move aten and code gen to shared buck file (pytorch#79966)
df6ed41 
Summary:
Pull Request resolved: pytorch#79966

move aten related targets to the shared buck file.

Leaving pt_operater_library intact for D36912042

Test Plan: Github CI, sandcastle

Reviewed By: iseeyuan

Differential Revision: D37323401

fbshipit-source-id: 2e8a668b33068bb85337ce43faecf3c83e5086d4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

linbinyu added a commit to linbinyu/pytorch that referenced this pull request Jun 22, 2022
@linbinyu @facebook-github-bot
[3] move aten and code gen to shared buck file (pytorch#79966)
4ec7a2c 
Summary:
Pull Request resolved: pytorch#79966

move aten related targets to the shared buck file.

Leaving pt_operater_library intact for D36912042

Test Plan: Github CI, sandcastle

Reviewed By: iseeyuan

Differential Revision: D37323401

fbshipit-source-id: e11b372fe1f7b1e90ed735c6eabd8d259a1263a7
@linbinyu linbinyu added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jun 22, 2022
@linbinyu @facebook-github-bot
[3] move aten and code gen to shared buck file (pytorch#79966)
71ad303 
Summary:
Pull Request resolved: pytorch#79966

move aten related targets to the shared buck file.

Leaving pt_operater_library intact for D36912042

Test Plan: Github CI, sandcastle

Reviewed By: iseeyuan

Differential Revision: D37323401

fbshipit-source-id: a58f87bd77ea642d1c2cb0bc2411e79d2338c2ef
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37323401

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @linbinyu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2022
@linbinyu @facebook-github-bot
[3] move aten and code gen to shared buck file (#79966)
1df3f34 
Summary:
Pull Request resolved: #79966

move aten related targets to the shared buck file.

Leaving pt_operater_library intact for D36912042

Test Plan: Github CI, sandcastle

Reviewed By: iseeyuan

Differential Revision: D37323401

fbshipit-source-id: 2f89ac2396997d6e51941f143d3c66db536ffc6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iseeyuan iseeyuan iseeyuan approved these changes

@kit1980 kit1980 Awaiting requested review from kit1980

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linbinyu @facebook-github-bot @pytorchmergebot @iseeyuan