-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Transform constraints to z3 constraints which is the final step #80110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 23cf49f (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
… step" [ghstack-poisoned]
… step" [ghstack-poisoned]
@migeed-z has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
@migeed-z has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot of code, but I like the test coverage so approving. I trust that this will be validated more in the future with the e2e cases
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
@pytorchbot merge -g |
@pytorchbot successfully started a merge job. Check the current status here |
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
Merge failed due to New commits were pushed while merging. Please rerun the merge command. |
… step" Differential Revision: [D37387508](https://our.internmc.facebook.com/intern/diff/D37387508) We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation. contains tests for alexnet and resnet as well as smaller examples [ghstack-poisoned]
@pytorchbot merge -g |
@pytorchbot successfully started a merge job. Check the current status here |
Hey @migeed-z. |
…) (#80110) Summary: Pull Request resolved: #80110 Approved by: https://github.com/anijain2305, https://github.com/jamesr66a Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/31952b56ebc438a2a331db4221fe03576896fa44 Reviewed By: mehtanirav Differential Revision: D37578968 Pulled By: migeed-z fbshipit-source-id: 35507af3210e110ffee558e9ec07b1a4eb5d76a0
Stack from ghstack (oldest at bottom):
Differential Revision: D37387508
We transform our constraints in a way that can be understood by z3. For example, for a dimension type, instead of Dyn, we encode it as a pair of integers. Some of the other operations are a 1:1 transformation.
contains tests for alexnet and resnet as well as smaller examples