Skip to content

Handle complex optimization in Adamax by treating complex numbers as 2D real numbers #80319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Handle complex optimization in Adamax by treating complex numbers as 2D real numbers #80319

wants to merge 1 commit into from

Conversation

zaxtax
Copy link
Contributor

@zaxtax zaxtax commented Jun 27, 2022

This commit partially addresses #65711

@zaxtax zaxtax requested a review from albanD as a code owner June 27, 2022 05:19
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 27, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 3b93dd5 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mruberry mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 27, 2022
albanD
albanD reviewed Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

@zaxtax zaxtax force-pushed the adamax-2d-complex branch 2 times, most recently from 27a1ae7 to 5d4b099 Compare August 5, 2022 10:14
albanD
albanD reviewed Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small not needed, sounds good otherwise.

torch/optim/adamax.py Outdated
@@ -229,6 +235,11 @@ def _single_tensor_adamax(params: List[Tensor],

param.addcdiv_(exp_avg, exp_inf, value=-clr)

if torch.is_complex(param):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

@zaxtax zaxtax force-pushed the adamax-2d-complex branch from 5d4b099 to 3b93dd5 Compare August 5, 2022 13:48
albanD
albanD approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@zaxtax
Copy link
Contributor Author

zaxtax commented Aug 5, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Hey @zaxtax.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 7, 2022
@zaxtax @facebook-github-bot
Handle complex optimization in Adamax by treating complex numbers as …
061de1d 
…2D real numbers (#80319) (#80319)

Summary:
This commit partially addresses #65711

Pull Request resolved: #80319
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c54d18dbc7bb2f9fdd83c5de529702e5a02295c3

Reviewed By: kit1980

Differential Revision: D38478847

fbshipit-source-id: 1174bc09fb1815d365dff6a44e2f0337501af1af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zaxtax @facebook-github-bot @pytorchmergebot @albanD @pytorchbot @mruberry