-
Notifications
You must be signed in to change notification settings - Fork 24.6k
Update buck_setup.sh #80467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buck_setup.sh #80467
Conversation
Add a parameter for proxy setup when running this script in devserver
🔗 Helpful links
❌ 19 New Failures, 1 Base FailuresAs of commit df576f9 (more details on the Dr. CI page): Expand to see more
🕵️ 19 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please do something like $PROXY_CONFIG=$1 and then use this variable rather than $1
scripts/buck_setup.sh
Outdated
@@ -1,4 +1,6 @@ | |||
#!/bin/bash | |||
$PROXY_CONFIG = $1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it how it supposed to be?
$PROXY_CONFIG = $1 | |
PROXY_CONFIG = "$1" |
tested on devserver |
@pytorchbot merge |
@pytorchbot successfully started a merge job. Check the current status here |
@linbinyu your PR has been successfully merged. |
Hey @linbinyu. |
Summary: Add a parameter for proxy setup when running this script in devserver Pull Request resolved: #80467 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d32ab80c323d6fda1aa19869c603d1adc7aa01bb Reviewed By: b0noI Differential Revision: D37509897 Pulled By: linbinyu fbshipit-source-id: d394281f397755d3487164c85540d52c4ddb83cc
Add a parameter for proxy setup when running this script in devserver