-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Convolution] Fix derivatives of convolution overrideable backward #80840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix the convolution_backward_overrideable always set param "transposed" as false to _convolution_double_backward. Backward of convolution_backward (convolution_double_backward) should be calculated with transposed or non-transposed mode.
Hi @Qiza-lyhm! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 688237d (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
need cla |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@pytorchbot merge -g |
@pytorchbot successfully started a merge job. Check the current status here |
Hey @Qiza-lyhm. |
…80840) (#80840) Summary: Fix the convolution_backward_overrideable always set param "transposed" as false to _convolution_double_backward. Backward of convolution_backward (convolution_double_backward) should be calculated with transposed or non-transposed mode. Fixes #80766 Pull Request resolved: #80840 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fce5560e0649013a0171eccf27e757f7ad91025d Reviewed By: mehtanirav Differential Revision: D37619033 Pulled By: mehtanirav fbshipit-source-id: c2ca7b3fc8d793db62383e832d31ba1769b53017
Fix the convolution_backward_overrideable always set param "transposed" as false to
_convolution_double_backward.
Backward of convolution_backward (convolution_double_backward) should be calculated
with transposed or non-transposed mode.
Fixes #80766