Skip to content

Conversation

Qiza-lyhm
Copy link
Contributor

Fix the convolution_backward_overrideable always set param "transposed" as false to
_convolution_double_backward.

Backward of convolution_backward (convolution_double_backward) should be calculated
with transposed or non-transposed mode.

Fixes #80766

Fix the convolution_backward_overrideable always set param "transposed" as false to
_convolution_double_backward.

Backward of convolution_backward (convolution_double_backward) should be calculated
with transposed or non-transposed mode.
@facebook-github-bot
Copy link
Contributor

Hi @Qiza-lyhm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 4, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 688237d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ezyang
Copy link
Contributor

ezyang commented Jul 4, 2022

need cla

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ezyang
Copy link
Contributor

ezyang commented Jul 5, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Hey @Qiza-lyhm.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 6, 2022
…80840) (#80840)

Summary:
Fix the convolution_backward_overrideable always set param "transposed" as false to
_convolution_double_backward.

Backward of convolution_backward (convolution_double_backward) should be calculated
with transposed or non-transposed mode.

Fixes #80766

Pull Request resolved: #80840
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fce5560e0649013a0171eccf27e757f7ad91025d

Reviewed By: mehtanirav

Differential Revision: D37619033

Pulled By: mehtanirav

fbshipit-source-id: c2ca7b3fc8d793db62383e832d31ba1769b53017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convolution overrideable missed transposed parameter
5 participants