Skip to content

Conversation

…add constraints for the expand operation

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 85849ba (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

migeed-z added a commit that referenced this pull request Jul 9, 2022
…add constraints for the expand operation

ghstack-source-id: 764e987
Pull Request resolved: #81175
…raints and add constraints for the expand operation"

[ghstack-poisoned]
migeed-z added a commit that referenced this pull request Jul 10, 2022
…add constraints for the expand operation

ghstack-source-id: 91248c7
Pull Request resolved: #81175
…raints and add constraints for the expand operation"

[ghstack-poisoned]
migeed-z added 2 commits July 11, 2022 15:09
…raints and add constraints for the expand operation"

[ghstack-poisoned]
…raints and add constraints for the expand operation"

[ghstack-poisoned]
…raints and add constraints for the expand operation"


Expand involves broadcasting, but we also know the output is constrained by the size given in the expand expression. So we generate similar constraints to addition but we constrain the output to the required size. 

[ghstack-poisoned]
@migeed-z
Copy link
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2659866728

…raints and add constraints for the expand operation"


Expand involves broadcasting, but we also know the output is constrained by the size given in the expand expression. So we generate similar constraints to addition but we constrain the output to the required size. 

[ghstack-poisoned]
@migeed-z
Copy link
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @migeed-z.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 14, 2022
…add constraints for the expand operation (#81175) (#81175)

Summary:
Expand involves broadcasting, but we also know the output is constrained by the size given in the expand expression. So we generate similar constraints to addition but we constrain the output to the required size.

Pull Request resolved: #81175
Approved by: https://github.com/jamesr66a

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/31142f57fc23edce291feaccf1670385e6239bbe

Reviewed By: DanilBaibak

Differential Revision: D37847329

Pulled By: migeed-z

fbshipit-source-id: 83b3bbcd4947a4f24c886bf318a6ec9a931de02a
@facebook-github-bot facebook-github-bot deleted the gh/migeed-z/17/head branch July 17, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants