-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Generalize the broadcasting interface for generating constraints and add constraints for the expand operation #81175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…add constraints for the expand operation [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 85849ba (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…raints and add constraints for the expand operation" [ghstack-poisoned]
…raints and add constraints for the expand operation" [ghstack-poisoned]
…raints and add constraints for the expand operation" [ghstack-poisoned]
…raints and add constraints for the expand operation" [ghstack-poisoned]
…raints and add constraints for the expand operation" Expand involves broadcasting, but we also know the output is constrained by the size given in the expand expression. So we generate similar constraints to addition but we constrain the output to the required size. [ghstack-poisoned]
@pytorchbot merge -g |
@pytorchbot successfully started a merge job. Check the current status here |
Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser |
…raints and add constraints for the expand operation" Expand involves broadcasting, but we also know the output is constrained by the size given in the expand expression. So we generate similar constraints to addition but we constrain the output to the required size. [ghstack-poisoned]
@pytorchbot merge -g |
@pytorchbot successfully started a merge job. Check the current status here |
Hey @migeed-z. |
…add constraints for the expand operation (#81175) (#81175) Summary: Expand involves broadcasting, but we also know the output is constrained by the size given in the expand expression. So we generate similar constraints to addition but we constrain the output to the required size. Pull Request resolved: #81175 Approved by: https://github.com/jamesr66a Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/31142f57fc23edce291feaccf1670385e6239bbe Reviewed By: DanilBaibak Differential Revision: D37847329 Pulled By: migeed-z fbshipit-source-id: 83b3bbcd4947a4f24c886bf318a6ec9a931de02a
Stack from ghstack (oldest at bottom):
Expand involves broadcasting, but we also know the output is constrained by the size given in the expand expression. So we generate similar constraints to addition but we constrain the output to the required size.