Skip to content

[PyTorch Edge] Fix ao::sparse::BCSR missing in qlinear serialize and deserialize when USE_FBGEMM and USE_PYTORCH_QNNPACK are not set #81256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[PyTorch Edge] Fix ao::sparse::BCSR missing in qlinear serialize and deserialize when USE_FBGEMM and USE_PYTORCH_QNNPACK are not set #81256

wants to merge 1 commit into from

Conversation

salilsdesai
Copy link
Contributor

Summary:
ao::sparse::BCSR is defined in packed_params.h, which is not included when USE_FBGEMM and USE_PYTORCH_QNNPACK are both not set. Fix this problem by surrounding the functions using ao::sparse::BCSR in qlinear_serialize and qlinear_deserialize with #ifdef USE_FBGEMM.

For more context, see:

Test Plan:
Build successful

time USE_CUDA=0 BUILD_CAFFE2_OPS=0 USE_XNNPACK=0 USE_FBGEMM=0 USE_DISTRIBUTED=0 USE_MKLDNN=0 USE_QNNPACK=0 BUILD_TEST=0 USE_GOLD_LINKER=1 USE_OPENMP=0 USE_PYTORCH_QNNPACK=0 DEBUG=1 python setup.py develop

Differential Revision: D37757170

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 11, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 0308eb0 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37757170

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37757170

@salilsdesai salilsdesai requested a review from kimishpatel July 13, 2022 15:14
@salilsdesai salilsdesai mentioned this pull request Jul 13, 2022
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37757170

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37757170

@salilsdesai @facebook-github-bot
[PyTorch Edge] Fix ao::sparse::BCSR missing in qlinear serialize and …
0308eb0 
…deserialize when USE_FBGEMM and USE_PYTORCH_QNNPACK are not set (pytorch#81256)

Summary:
Pull Request resolved: pytorch#81256

ao::sparse::BCSR is defined in packed_params.h, which is not included when USE_FBGEMM and USE_PYTORCH_QNNPACK are both not set. Fix this problem by surrounding the functions using ao::sparse::BCSR in qlinear_serialize and qlinear_deserialize with ```#ifdef USE_FBGEMM```.

For more context, see:
- pytorch#81081
- pytorch#81178

Test Plan:
Build successful

```time USE_CUDA=0 BUILD_CAFFE2_OPS=0 USE_XNNPACK=0 USE_FBGEMM=0 USE_DISTRIBUTED=0 USE_MKLDNN=0 USE_QNNPACK=0 BUILD_TEST=0 USE_GOLD_LINKER=1 USE_OPENMP=0 USE_PYTORCH_QNNPACK=0 DEBUG=1 python setup.py develop```

Reviewed By: kirklandsign

Differential Revision: D37757170

fbshipit-source-id: 69f357ab2b579decd17d629a8a12d40bcccb68b5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37757170

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @salilsdesai.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 14, 2022
@salilsdesai @facebook-github-bot
[PyTorch Edge] Fix ao::sparse::BCSR missing in qlinear serialize and …
1554314 
…deserialize when USE_FBGEMM and USE_PYTORCH_QNNPACK are not set (#81256)

Summary:
Pull Request resolved: #81256

ao::sparse::BCSR is defined in packed_params.h, which is not included when USE_FBGEMM and USE_PYTORCH_QNNPACK are both not set. Fix this problem by surrounding the functions using ao::sparse::BCSR in qlinear_serialize and qlinear_deserialize with ```#ifdef USE_FBGEMM```.

For more context, see:
- #81081
- #81178

Test Plan:
Build successful

```time USE_CUDA=0 BUILD_CAFFE2_OPS=0 USE_XNNPACK=0 USE_FBGEMM=0 USE_DISTRIBUTED=0 USE_MKLDNN=0 USE_QNNPACK=0 BUILD_TEST=0 USE_GOLD_LINKER=1 USE_OPENMP=0 USE_PYTORCH_QNNPACK=0 DEBUG=1 python setup.py develop```

Reviewed By: kirklandsign

Differential Revision: D37757170

fbshipit-source-id: 0e0fdf6efe1a633a2db2e6040eb4d98fac2644df
@salilsdesai salilsdesai mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@kimishpatel kimishpatel kimishpatel approved these changes

Assignees
No one assigned
Labels
cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@salilsdesai @facebook-github-bot @pytorchmergebot @ezyang @kimishpatel