Skip to content

[MPS] Handle Boolean inputs in the cat op #81480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Handle Boolean inputs in the cat op #81480

wants to merge 2 commits into from

Conversation

kulinseth
Copy link
Collaborator

Fixes #80850

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit a390c7e (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kulinseth kulinseth requested review from razarmehr July 14, 2022 18:27
razarmehr
razarmehr approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kulinseth
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @kulinseth.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 15, 2022
@DenisVieriu97 @facebook-github-bot
[MPS] Handle Boolean inputs in the cat op (#81480) (#81480)
8b3b912 
Summary:
Fixes #80850

Pull Request resolved: #81480
Approved by: https://github.com/razarmehr

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e3b98ba7a466ed98e3ca04714203ff7cb9d0dbe8

Reviewed By: DanilBaibak

Differential Revision: D37876475

Pulled By: DanilBaibak

fbshipit-source-id: 6406fca87cc2fda0f621b3c2a6f1ec3668cedc2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razarmehr razarmehr Awaiting requested review from razarmehr

Assignees
No one assigned
Labels
cla signed Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mps Torch Stack Return Value
7 participants
@kulinseth @facebook-github-bot @pytorchmergebot @razarmehr @pytorchbot @DenisVieriu97 @abhudev