Skip to content

[vulkan] implement quantize per tensor #81492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[vulkan] implement quantize per tensor #81492

wants to merge 1 commit into from

Conversation

psavla2
Copy link
Contributor

@psavla2 psavla2 commented Jul 14, 2022 •
edited
Loading

@psavla2
[vulkan] implement quantize per tensor
da4c125 
for T121382131
implement quantize_per_tensor function and corresponding shader

Differential Revision: [D37318641](https://our.internmc.facebook.com/intern/diff/D37318641/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit da4c125 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jul 14, 2022
Closed
Closed
Closed
Closed
Closed
Closed
salilsdesai
salilsdesai approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@salilsdesai salilsdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @psavla2.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 15, 2022
@psavla2 @facebook-github-bot
[vulkan] implement quantize per tensor (#81492)
27e5091 
Summary:
Pull Request resolved: #81492

for T121382131
implement quantize_per_tensor function and corresponding shader
ghstack-source-id: 161533770

Test Plan:
wrote unit test and directly call function
buck run //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac

Reviewed By: SS-JIA

Differential Revision: D37318641

fbshipit-source-id: da0e27c770159b58f202b49af4df236547b0a667
@facebook-github-bot facebook-github-bot deleted the gh/psavla2/12/head branch July 19, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salilsdesai salilsdesai salilsdesai approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psavla2 @facebook-github-bot @pytorchmergebot @salilsdesai