Skip to content

[vulkan] implement quantized sub #81632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[vulkan] implement quantized sub #81632

wants to merge 8 commits into from

Conversation

psavla2
Copy link
Contributor

@psavla2 psavla2 commented Jul 18, 2022 •
edited
Loading

@psavla2
[vulkan] implement quantized sub
175482c 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 18, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 0b33a69 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jul 18, 2022
Closed
Closed
Closed
Closed
Closed
Closed
psavla2 added a commit that referenced this pull request Jul 18, 2022
@psavla2
[vulkan] implement quantized sub
154a325 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

ghstack-source-id: 161758307
Pull Request resolved: #81632
@psavla2
Update on "[vulkan] implement quantized sub"
5c4088d 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
This was referenced Jul 18, 2022
Closed
Closed
@psavla2
Update on "[vulkan] implement quantized sub"
d42e17c 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
@psavla2 psavla2 mentioned this pull request Jul 19, 2022
Closed
psavla2 added 2 commits July 20, 2022 11:53
@psavla2
Update on "[vulkan] implement quantized sub"
d609104 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
@psavla2
Update on "[vulkan] implement quantized sub"
9944636 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
@psavla2 psavla2 requested a review from SS-JIA July 20, 2022 19:51
@psavla2
Update on "[vulkan] implement quantized sub"
6bcbda3 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
@psavla2 psavla2 mentioned this pull request Jul 21, 2022
Closed
psavla2 added 2 commits July 21, 2022 12:10
@psavla2
Update on "[vulkan] implement quantized sub"
f8fd842 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
@psavla2
Update on "[vulkan] implement quantized sub"
0b33a69 
implemented quantized sub operator

Differential Revision: [D37923502](https://our.internmc.facebook.com/intern/diff/D37923502/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @psavla2.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 26, 2022
@psavla2 @facebook-github-bot
[vulkan] implement quantized sub (#81632)
b7158f5 
Summary:
Pull Request resolved: #81632

implemented quantized sub operator
ghstack-source-id: 162439164

Test Plan: buck run //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac

Reviewed By: SS-JIA

Differential Revision: D37923502

fbshipit-source-id: 6911d18379b9df99c406643c59545339589ff63c
@facebook-github-bot facebook-github-bot deleted the gh/psavla2/20/head branch July 29, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psavla2 @facebook-github-bot @pytorchmergebot @SS-JIA