Dispatch the auxiliary frobenius_norm and nuclear_norm to better implementations and deprecate them #81763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementations and deprecate them These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all [ghstack-poisoned]
This was referenced Jul 20, 2022
🔗 Helpful links
❌ 30 New FailuresAs of commit 3df05c6 (more details on the Dr. CI page): Expand to see more
🕵️ 30 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
lezcano
added a commit
that referenced
this pull request
Jul 20, 2022
…ementations and deprecate them These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all ghstack-source-id: d269c3d Pull Request resolved: #81763
lezcano
requested review from
ngimel
and removed request for
nikitaved and
IvanYashchuk
lezcano
added
module: linear algebra
|
About BC compatibility. We run the same test as described in #81761 (comment) |
…better implementations and deprecate them" These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Jul 20, 2022
…ementations and deprecate them These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all ghstack-source-id: c4c9f3f Pull Request resolved: #81763
…better implementations and deprecate them" These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all [ghstack-poisoned]
…better implementations and deprecate them" These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Jul 20, 2022
…ementations and deprecate them These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all ghstack-source-id: 13dfc6d Pull Request resolved: #81763
…better implementations and deprecate them" These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all [ghstack-poisoned]
…better implementations and deprecate them" These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all [ghstack-poisoned]
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Rebase failed due to Raised by https://github.com/pytorch/pytorch/actions/runs/3914524063 |
|
@lezcano Could you rebase? |
…better implementations and deprecate them" These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano ezyang ngimel peterbell10 Differential Revision: [D42354776](https://our.internmc.facebook.com/intern/diff/D42354776) [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Jan 14, 2023
implementations and deprecate them These functions will be legacy functions. We deprecate them, but we also take this chance to dispatch to a more efficient and consistent implementation. Doing so should help writing a conversion rule for these to be able to remove them once and for all ghstack-source-id: f3533f9 Pull Request resolved: #81763
|
@kit1980 done! |
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'This breaks XLA test https://hud.pytorch.org/pytorch/pytorch/commit/34e8eb229db76f7f5eb8f18c062dbd1ee47f8b12' -c landrace |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
Can't revert PR that was landed via phabricator as D42354776. Please revert by going to the internal diff and clicking Unland. |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 21, 2023
To be reverted once the issue is mitigated https://hud.pytorch.org/failure/%5B%20%20FAILED%20%20%5D%20AtenXlaTensorTest.TestFrobeniusNormInDims Caused by #81763 Pull Request resolved: #92634 Approved by: https://github.com/ZainRizvi
|
Here is the XLA test that needs to be updated: https://github.com/pytorch/xla/blob/master/test/cpp/test_aten_xla_tensor.cpp#L1887 |
|
Or we can just delete the test as did pytorch/xla#3976 |
|
uh, no, we should fix that. Odd that that happened, ci was green... |
|
Right, this is an issue with some new symint stuff. I'll look into that. |
|
@lezcano don't reopen this PR, we didn't actually revert this. |
|
Sure thing, will do that on Monday. |
lezcano
added a commit
to pytorch/xla
that referenced
this pull request
Jan 23, 2023
See pytorch/pytorch#81763 (comment) and pytorch/pytorch#81763 (comment) Now FrobeniusNorm is just left for backwards compatibility, and it dispatches to `at::norm`, which dispatches to `xla::norm`. As such, we don't need the `sqrt` counters as they will not be updated. We remove these checks as those from `TestNorm*` do not have them either.
kit1980
pushed a commit
to pytorch/xla
that referenced
this pull request
Jan 23, 2023
See pytorch/pytorch#81763 (comment) and pytorch/pytorch#81763 (comment) Now FrobeniusNorm is just left for backwards compatibility, and it dispatches to `at::norm`, which dispatches to `xla::norm`. As such, we don't need the `sqrt` counters as they will not be updated. We remove these checks as those from `TestNorm*` do not have them either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These functions will be legacy functions. We deprecate them, but we also
take this chance to dispatch to a more efficient and consistent implementation.
Doing so should help writing a conversion rule for these to be able to
remove them once and for all
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano @ezyang @ngimel @peterbell10
Differential Revision: D42354776