Skip to content

[PyTorch] Solved two syntax issues when dumping execution graph result to json file. #81854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[PyTorch] Solved two syntax issues when dumping execution graph result to json file. #81854

wants to merge 1 commit into from

Conversation

louisfeng
Copy link
Contributor

Summary:
Solved two syntax issues when dumping execution graph outputs to a json file.

  1. Added workarounds to properly dump inf/nan values.
  2. Added support for JSON string escape.

Test Plan:

buck build mode/dev-nosan caffe2/test:profiler --show-output
buck-out/gen/caffe2/test/profiler#binary.par test_profiler.TestExecutionGraph.test_execution_graph_start_stop

Differential Revision: D37292316

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit ced9684 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37292316

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37292316

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37292316

@chaekit chaekit self-requested a review August 8, 2022 18:28
@mingyul-fb @facebook-github-bot
[PyTorch] Solved two syntax issues when dumping execution graph resul…
ced9684 
…t to json file. (pytorch#81854)

Summary:
Pull Request resolved: pytorch#81854

Solved two syntax issues when dumping execution graph outputs to a json file.
1. Added workarounds to properly dump inf/nan values.
2. Added support for JSON string escape.

Test Plan:
```
buck build mode/dev-nosan caffe2/test:profiler --show-output
buck-out/gen/caffe2/test/profiler#binary.par test_profiler.TestExecutionGraph.test_execution_graph_start_stop
```
Output execution graph: P518622984

Reviewed By: louisfeng, chaekit, aaronenyeshi

Differential Revision: D37292316

fbshipit-source-id: f2cc663528fc508913731ee47f48e39297478d93
@louisfeng louisfeng requested a review from robieta as a code owner August 10, 2022 18:16
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37292316

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @louisfeng.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 11, 2022
@mingyul-fb @facebook-github-bot
[PyTorch] Solved two syntax issues when dumping execution graph resul…
556d45f 
…t to json file. (#81854)

Summary:
Pull Request resolved: #81854

Solved two syntax issues when dumping execution graph outputs to a json file.
1. Added workarounds to properly dump inf/nan values.
2. Added support for JSON string escape.

Test Plan:
```
buck build mode/dev-nosan caffe2/test:profiler --show-output
buck-out/gen/caffe2/test/profiler#binary.par test_profiler.TestExecutionGraph.test_execution_graph_start_stop
```
Output execution graph: P518622984

Reviewed By: louisfeng, chaekit, aaronenyeshi

Differential Revision: D37292316

fbshipit-source-id: 1f07813a63de9b71d022f499fd4190ee3207ec96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaekit chaekit chaekit approved these changes

@robieta robieta Awaiting requested review from robieta

+1 more reviewer

@rajshahdev rajshahdev rajshahdev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@louisfeng @facebook-github-bot @pytorchmergebot @chaekit @rajshahdev @mingyul-fb